Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mtd: rawnand: Add Phytium NAND flash controller support #199

Merged

Conversation

studyhu
Copy link

@studyhu studyhu commented May 23, 2024

This patch implements a device driver of NAND flash controller for both Phytium PCIe chipset and SoCs. Since interrupt flags depends on the bus implementation, e.g., PCI vs platform, we extract the interrupt register function from NFC driver core.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign utsweetyfish for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

Hi @studyhu. Thanks for your PR.

I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@opsiff
Copy link
Member

opsiff commented May 24, 2024

/ok-to-test

drivers/mtd/nand/raw/phytium_nand.c Show resolved Hide resolved
}

static int phytium_nand_get_ecc_total(struct mtd_info *mtd,
struct nand_ecc_ctrl *ecc)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代码对齐

drivers/mtd/nand/raw/phytium_nand.c Show resolved Hide resolved
drivers/mtd/nand/raw/phytium_nand.c Show resolved Hide resolved
/* Configure the DMA */
phytium_nfc_init_dma(nfc);


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

空行太多

This patch implements a device driver of NAND flash controller
for both Phytium PCIe chipset and SoCs. Since interrupt flags
depends on the bus implementation, e.g., PCI vs platform,
we extract the interrupt register function from NFC driver core.

Signed-off-by: Zhu Mingshuai <[email protected]>
Signed-off-by: Zhou Yulin <[email protected]>
Signed-off-by: Chen Baozi <[email protected]>
Signed-off-by: Wang Yinfeng <[email protected]>
Signed-off-by: Hu Yeqing <[email protected]>
@studyhu studyhu force-pushed the linux-6.6.y-nand branch from 12e20f8 to 5ec9faa Compare May 28, 2024 03:10
@deepin-ci-robot
Copy link

deepin pr auto review

This patch adds the Phytium NAND controller driver for Linux. The driver
supports the following features:

  • NAND command translation
  • NAND register read/write
  • NAND page read/write
  • NAND block read/write
  • NAND flash erase
  • NAND flash read
  • NAND flash write
  • NAND flash ECC

The driver is developed for the Phytium X100 development board and
passes the autotest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants