Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(kernel-rolling) arch: Add LoongArch LS2K500 Framebuffer and IPMI/BMC support #183

Conversation

MingcongBai
Copy link
Contributor

@MingcongBai MingcongBai commented May 22, 2024

Picked and rebased from #143. This is a split pull request to separate commits for cpufreq and ls2k500 (IPMI, BMC, and Framebuffer).

Builds tested

  • amd64
  • arm64
  • loong64

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tsic404 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

Hi @MingcongBai. Thanks for your PR.

I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Yanteng Si and others added 5 commits May 29, 2024 08:36
Signed-off-by: Chong Qiao <[email protected]>
Signed-off-by: Hongchen Zhang <[email protected]>
Signed-off-by: Yanteng Si <[email protected]>
Signed-off-by: Chong Qiao <[email protected]>
Signed-off-by: Hongchen Zhang <[email protected]>
Signed-off-by: Yanteng Si <[email protected]>
Signed-off-by: Chong Qiao <[email protected]>
Signed-off-by: Hongchen Zhang <[email protected]>
Signed-off-by: Yanteng Si <[email protected]>
Enable ls2k500sfb as a module in deepin_loongarch_desktop_defconfig and loongson3_defconfig.
@MingcongBai MingcongBai force-pushed the bai/kernel-rolling/loongarch-ls2k500 branch from 4b0c2e9 to d6e6f92 Compare May 29, 2024 00:36
@deepin-ci-robot
Copy link

deepin pr auto review

Fix red warning about missing include

Signed-off-by: Alvaro Saurin [email protected]

@MingcongBai
Copy link
Contributor Author

MingcongBai commented May 29, 2024

Fails to build on loong64:

drivers/video/fbdev/ls2k500sfb.c:256:13: error: no previous prototype for 'ls2k500sfb_interrupt' [-Werror=missing-prototypes]
  256 | irqreturn_t ls2k500sfb_interrupt(int irq, void *arg)
      |             ^~~~~~~~~~~~~~~~~~~~                                                                  
drivers/video/fbdev/ls2k500sfb.c: In function 'get_gpio_irq_from_acpi_table':
drivers/video/fbdev/ls2k500sfb.c:291:23: error: 'chip' is used uninitialized [-Werror=uninitialized]
  291 |         chip->gpiodev = gpio_device_find_by_label("LOON0007:00");
      |         ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/ls2k500sfb.c:288:27: note: 'chip' was declared here
  288 |         struct gpio_chip *chip;
      |                           ^~~~
cc1: all warnings being treated as errors

@Avenger-285714 @opsiff

@opsiff
Copy link
Member

opsiff commented Jun 12, 2024

是不是按之前这么改就行

Link:AOSC-Tracking/linux@3df62ce

Fails to build on loong64:

drivers/video/fbdev/ls2k500sfb.c:256:13: error: no previous prototype for 'ls2k500sfb_interrupt' [-Werror=missing-prototypes]
  256 | irqreturn_t ls2k500sfb_interrupt(int irq, void *arg)
      |             ^~~~~~~~~~~~~~~~~~~~                                                                  
drivers/video/fbdev/ls2k500sfb.c: In function 'get_gpio_irq_from_acpi_table':
drivers/video/fbdev/ls2k500sfb.c:291:23: error: 'chip' is used uninitialized [-Werror=uninitialized]
  291 |         chip->gpiodev = gpio_device_find_by_label("LOON0007:00");
      |         ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/ls2k500sfb.c:288:27: note: 'chip' was declared here
  288 |         struct gpio_chip *chip;
      |                           ^~~~
cc1: all warnings being treated as errors

@Avenger-285714 @opsiff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants