Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(kernel-rolling) dt-bindings: ipmi: Add bindings for Phytium KCS #177

Conversation

MingcongBai
Copy link
Contributor

@MingcongBai MingcongBai commented May 22, 2024

Picked and rebased from #125.

From original pull request:

This patch documents the DT bindings for Phytium KCS interface.

Builds tested

  • amd64
  • arm64
  • loong64

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign yukarichiba for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

Hi @MingcongBai. Thanks for your PR.

I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This patch documents the DT bindings for Phytium KCS interface.

Signed-off-by: Li Yuting <[email protected]>
Signed-off-by: Chen Baozi <[email protected]>
Signed-off-by: Wang Yinfeng <[email protected]>
@MingcongBai MingcongBai force-pushed the bai/kernel-rolling/phytium-kcs-ipmi branch from 37011e4 to 2f4230d Compare May 29, 2024 00:39
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 代码格式和风格保持一致,没有发现缩进或括号使用不当的问题。
  • 属性定义和注释清晰,易于理解。
  • 使用了$ref来引用类型定义,提高了代码的可维护性。

是否建议立即修改:

  • 否,当前提交的代码质量较高,没有发现需要立即修改的关键问题。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants