-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lpc: phytium: Add LPC snoop driver #160
Conversation
This patch documents the DT binding for the Phytium lpc-snoop driver. Signed-off-by: Li Yuting <[email protected]> Signed-off-by: Lan Hengyu <[email protected]> Signed-off-by: Wang Yinfeng <[email protected]>
The LPC snoop driver is used to monitor the startup progress of the CPU side Server. Generally,port 0x80 is used. The usage is as follows: The firmware writes the current system startup progress to port 0x80 during the server CPU side startup, and then the system has an APP program to obtain the data on port 0x80 from the snoop and output it to the terminal. Signed-off-by: Li Yuting <[email protected]> Signed-off-by: Lan Hengyu <[email protected]> Signed-off-by: Wang Yinfeng <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @lyt31. Thanks for your PR. I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
snp_addr_reg_shift = snp_addr_reg_snp2_shift; | ||
break; | ||
default: | ||
return -EINVAL; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
审核意见:phytium_lpc_enable_snoop传入channel都是 0或1时是正常的 如果调用者传递的channel不是 0或1此处没有调用kfifo_free
/ok-to-test |
deepin pr auto review关键摘要:
|
This patch documents the DT binding for the Phytium lpc-snoop driver.
The LPC snoop driver is used to monitor the startup progress of the CPU
side Server. Generally,port 0x80 is used.
The usage is as follows: The firmware writes the current system
startup progress to port 0x80 during the server CPU side startup,
and then the system has an APP program to obtain the data on port
0x80 from the snoop and output it to the terminal.