-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
usb: phytium: Add support for Phytium USB controller #140
usb: phytium: Add support for Phytium USB controller #140
Conversation
This patch documents the DT binding for the Phytium USBHS-DRD controller. Signed-off-by: Wang Zhimin <[email protected]> Signed-off-by: Chen Baozi <[email protected]> Signed-off-by: Wang Yinfeng <[email protected]>
This patch adds the Phytium USBHS DRD controller support. Signed-off-by: Wang Zhimin <[email protected]> Signed-off-by: Li Mingzhe <[email protected]> Signed-off-by: Zuo Qian <[email protected]> Signed-off-by: Chen Zhenhua <[email protected]> Signed-off-by: Chen Baozi <[email protected]> Signed-off-by: Wang Yinfeng <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @wangzhimin1179. Thanks for your PR. I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
phytium_write32(&priv->regs->ep_sts, DMARF_EP_ISOERR); | ||
trbChainDesc = GetTrbChainDescEntry(channel->trbChainDescList.next); | ||
trbChainDesc->isoError = 1; | ||
goto retransmit; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
检查goto retransmit,建议换写法,尽量不要横跨if去goto
@@ -0,0 +1,22 @@ | |||
config USB_PHYTIUM | |||
tristate "PHYTIUM USB Support" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
建议和飞腾其它驱动配置项保持一致,PHYTIUM改为Phytium
trb.dmaSize = 0; \ | ||
trb.ctrl = 0; } | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
多了行空行嘛
#define __PHYTIUM_DMA_H__ | ||
|
||
#include <linux/types.h> | ||
//#include "list.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这行注释的意义是?
#define TD_DMULT_MAX_TRB_DATA_SIZE 65536u | ||
#define TD_DMULT_MAX_TD_DATA_SIZE (~1u) | ||
#define TD_SING_MAX_TRB_DATA_SIZE 65536u | ||
#define TD_SING_MAX_TD_DATA_SIZE 65536u |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这一段4个define没有对齐
|
||
phytium_write8(&priv->regs->fnaddr, usbEpPriv->faddress); | ||
|
||
// if (usbEpPriv->type == USB_ENDPOINT_XFER_INT) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这行注释的意义是?
return 0; | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
多了行空行嘛
|
||
static int set_PortFeature(struct HOST_CTRL *priv, u16 wValue, u16 wIndex) | ||
{ | ||
// struct HW_Regs *regs = priv->regs; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这行注释的意义是?
#define __PHYTIUM_HOST_API_H_ | ||
|
||
#include <linux/usb/ch9.h> | ||
//#include "list.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这行注释的意义是?
// SPDX-License-Identifier: GPL-2.0 | ||
#include <linux/module.h> | ||
#include <linux/kernel.h> | ||
//#include <linux/usb/hcd.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这行注释的意义是?
先close掉。 |
This patch adds the Phytium USBHS DRD controller support. a e2000 can Simulate a USB storage device ,and so on。