Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipmi: Add Phytium KCS IPMI BMC driver support #134

Merged
merged 1 commit into from
May 13, 2024
Merged

ipmi: Add Phytium KCS IPMI BMC driver support #134

merged 1 commit into from
May 13, 2024

Conversation

lyt31
Copy link
Contributor

@lyt31 lyt31 commented May 13, 2024

This driver exposes the KCS interface on Phytium SOCs as a character device. Such SOCs are commonly used as BMCs and this driver implements the BMC side of the KCS interface.

@deepin-ci-robot
Copy link

Hi @lyt31. Thanks for your PR.

I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Avenger-285714
Copy link
Collaborator

/ok-to-test

depends on ARCH_PHYTIUM
select IPMI_KCS_BMC
select REGMAP_MMIO
tristate "PHYTIUM KCS IPMI BMC driver"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

麻烦在Kconfig中统一写法,建议在Prompt这种解释性文字中使用"Phytium"代替“PHYTIUM”,这样可识度更高

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的

}
}
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多了个空行嘛

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改


rc = regmap_update_bits(priv->map, reg, mask, val);
WARN(rc != 0, "regmap_update_bits() failed: %d\n", rc);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

少了个空行嘛

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

This driver exposes the KCS interface on Phytium SOCs as a
character device. Such SOCs are commonly used as BMCs and this driver
implements the BMC side of the KCS interface.

Signed-off-by: Li Yuting <[email protected]>
Signed-off-by: Cheng Quan <[email protected]>
Signed-off-by: Chen Zhenhua <[email protected]>
Signed-off-by: Chen Baozi <[email protected]>
Signed-off-by: Wang Yinfeng <[email protected]>
@Avenger-285714
Copy link
Collaborator

Great! Love from deepin kernel SIG.

@Avenger-285714
Copy link
Collaborator

/approve

@Avenger-285714 Avenger-285714 merged commit 1472a37 into deepin-community:linux-6.6.y May 13, 2024
1 of 2 checks passed
@deepin-ci-robot
Copy link

deepin pr auto review

This patch adds a new driver for the KCS BMC device. The driver is
specific to the Phytium server board and is used to communicate with
the onboard KCS BMC device. The driver provides methods for reading
and writing data to the KCS BMC device, and manages its lifecycle
including initialization, configuration, and removal.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Avenger-285714
Once this PR has been reviewed and has the lgtm label, please assign yukarichiba for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants