-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ipmi: Add Phytium KCS IPMI BMC driver support #134
ipmi: Add Phytium KCS IPMI BMC driver support #134
Conversation
Hi @lyt31. Thanks for your PR. I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
drivers/char/ipmi/Kconfig
Outdated
depends on ARCH_PHYTIUM | ||
select IPMI_KCS_BMC | ||
select REGMAP_MMIO | ||
tristate "PHYTIUM KCS IPMI BMC driver" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
麻烦在Kconfig中统一写法,建议在Prompt这种解释性文字中使用"Phytium"代替“PHYTIUM”,这样可识度更高
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的
} | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
多了个空行嘛
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改
|
||
rc = regmap_update_bits(priv->map, reg, mask, val); | ||
WARN(rc != 0, "regmap_update_bits() failed: %d\n", rc); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
少了个空行嘛
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改
This driver exposes the KCS interface on Phytium SOCs as a character device. Such SOCs are commonly used as BMCs and this driver implements the BMC side of the KCS interface. Signed-off-by: Li Yuting <[email protected]> Signed-off-by: Cheng Quan <[email protected]> Signed-off-by: Chen Zhenhua <[email protected]> Signed-off-by: Chen Baozi <[email protected]> Signed-off-by: Wang Yinfeng <[email protected]>
Great! Love from deepin kernel SIG. |
/approve |
1472a37
into
deepin-community:linux-6.6.y
deepin pr auto reviewThis patch adds a new driver for the KCS BMC device. The driver is |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Avenger-285714 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This driver exposes the KCS interface on Phytium SOCs as a character device. Such SOCs are commonly used as BMCs and this driver implements the BMC side of the KCS interface.