Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i2c: add Phytium i2c driver for both server and desktop platform #123

Merged
merged 4 commits into from
May 13, 2024

Conversation

JiakunShuai
Copy link
Contributor

Add Phytium i2c driver and its dt-bindings yaml documents.
This driver is for both server and desktop platform using.

This patch documents the DT binding for the Phytium I2C controller
with SMBus alert interrupt support.

Signed-off-by: Chen Baozi <[email protected]>
Signed-off-by: Wang Yinfeng <[email protected]>
Signed-off-by: Jiakun Shuai <[email protected]>
Add a driver for Phytium I2C controller with SMBus alert interrupt support.

Signed-off-by: Cheng Quan <[email protected]>
Signed-off-by: Feng Jun <[email protected]>
Signed-off-by: Chen Baozi <[email protected]>
Signed-off-by: Wang Yinfeng <[email protected]>
Signed-off-by: Jiakun Shuai <[email protected]>
Phytium I2C adapter is compatible with Synopsys Designware, so we reuse its
driver and add the Phytium's ACPI description to it.

Signed-off-by: Chen Baozi <[email protected]>
Signed-off-by: Wang Yinfeng <[email protected]>
Signed-off-by: Jiakun Shuai <[email protected]>
Add the input frequency of 200MHz for the Phytium I2C controller block.
The ACPI ID used is "PHYT0003".

Signed-off-by: Wang Yinfeng <[email protected]>
Signed-off-by: Chen Baozi <[email protected]>
Signed-off-by: Jiakun Shuai <[email protected]>
@deepin-ci-robot deepin-ci-robot requested a review from tsic404 May 9, 2024 09:56
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign goldendeng for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

Hi @JiakunShuai. Thanks for your PR.

I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JiakunShuai JiakunShuai changed the title Add Phytium i2c driver for both Server and Desktop platform. i2c: add Phytium i2c driver for both server and desktop platform May 9, 2024
@Avenger-285714
Copy link
Collaborator

/ok-to-test

@@ -246,6 +251,7 @@ static const struct acpi_device_id acpi_apd_device_ids[] = {
{ "HISI02A3", APD_ADDR(hip08_lite_i2c_desc) },
{ "HISI0173", APD_ADDR(hip08_spi_desc) },
{ "NXP0001", APD_ADDR(nxp_i2c_desc) },
{ "PHYT0003", APD_ADDR(phytium_i2c_desc) },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

根据飞腾ACPI规范文档v1.2版本 p13页所说和一些旧代码的内容,
这里下面还需要添加FTI20001?
As Phytium ACPI Description Specification document v1.2 p13
Device HID said for old v1.0 Spec,FTI20001 is need?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

目前飞腾向主流开源社区推送的版本已经剔除了CID属性,如果还在使用acpi v1.0的旧规范的话建议是升级固件了,有很多属性acpi v1.0都不支持的。

@@ -57,6 +57,7 @@ static const struct acpi_device_id dw_i2c_acpi_match[] = {
{ "HISI02A2", 0 },
{ "HISI02A3", 0 },
{ "HYGO0010", ACCESS_INTR_MASK },
{ "PHYT0003", 0 },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

@Avenger-285714 Avenger-285714 merged commit 8940089 into deepin-community:linux-6.6.y May 13, 2024
1 of 2 checks passed
Avenger-285714 added a commit that referenced this pull request May 13, 2024
#123"

Add Phytium i2c driver and its dt-bindings yaml documents.
This driver is for both server and desktop platform using.

Include follow 4 commits:
* 8940089 ACPI: APD: Add clock frequency for Phytium I2C controller
  c770de6 i2c: designware: add i2c support for Phytium SoCs
  71507aa i2c: phytium: Add i2c driver for Phytium I2C adapter
  9437fe7 dt-bindings: Add bindings for Phytium I2C/SMBus controller

Signed-off-by: Jiakun Shuai <[email protected]>
Signed-off-by: WangYuli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants