Skip to content

Commit

Permalink
debian: firmware_loader: Log direct loading failures as info for d-i
Browse files Browse the repository at this point in the history
On an installed Debian system, firmware packages will normally be
installed automatically based on a mapping of device IDs to firmware.
Within the Debian installer this has not yet happened and we need a
way to detect missing firmware.

Although many/most drivers log firmware loading failures, they do so
using many different formats.  This adds a single log message to the
firmware loader, which the installer's hw-detect package will look
for.  The log level is set to "info" because some failures are
expected and we do not want to confuse users with bogus error messages
(like in bug #966218).

NOTE: The log message format must not be changed without coordinating
this with the check-missing-firmware.sh in hw-detect.

Link: https://salsa.debian.org/kernel-team/linux/-/blob/debian/6.11/trixie/debian/patches/debian/firmware_loader-log-direct-loading-failures-as-info-for-d-i.path
Signed-off-by: Wentao Guan <[email protected]>
  • Loading branch information
benh-debian authored and opsiff committed Nov 19, 2024
1 parent 6a1e581 commit fc35d6b
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions drivers/base/firmware_loader/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -585,6 +585,10 @@ fw_get_filesystem_firmware(struct device *device, struct fw_priv *fw_priv,
}
__putname(path);

if (rc)
dev_info(device, "firmware: failed to load %s (%d)\n",
fw_priv->fw_name, rc);

return rc;
}

Expand Down

0 comments on commit fc35d6b

Please sign in to comment.