Skip to content

Commit

Permalink
cpufreq: ACPI: add ITMT support when CPPC enabled
Browse files Browse the repository at this point in the history
zhaoxin inclusion
category: bugfix

-------------------

The _CPC method can get per-core highest frequency.
The highest frequency may varies between cores which mean cores can
running at different max frequency, so can use it as a core priority
and give a hint to scheduler in order to put critical task to the
higher priority core.

Signed-off-by: leoliu-oc <[email protected]>
  • Loading branch information
leoliu-oc committed Jun 14, 2024
1 parent 5086b5c commit e28f977
Show file tree
Hide file tree
Showing 2 changed files with 70 additions and 13 deletions.
2 changes: 2 additions & 0 deletions arch/x86/kernel/itmt.c
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ int sched_set_itmt_support(void)

return 0;
}
EXPORT_SYMBOL_GPL(sched_set_itmt_support);

/**
* sched_clear_itmt_support() - Revoke platform's support of ITMT
Expand Down Expand Up @@ -181,3 +182,4 @@ void sched_set_itmt_core_prio(int prio, int cpu)
{
per_cpu(sched_core_priority, cpu) = prio;
}
EXPORT_SYMBOL_GPL(sched_set_itmt_core_prio);
81 changes: 68 additions & 13 deletions drivers/cpufreq/acpi-cpufreq.c
Original file line number Diff line number Diff line change
Expand Up @@ -628,28 +628,35 @@ static int acpi_cpufreq_blacklist(struct cpuinfo_x86 *c)
#endif

#ifdef CONFIG_ACPI_CPPC_LIB
static u64 get_max_boost_ratio(unsigned int cpu)
static bool cppc_highest_perf_diff;
static struct cpumask core_prior_mask;

static void cppc_get_highest_nominal_perf(int cpu, u64 *highest_perf, u64 *nominal_perf)
{
struct cppc_perf_caps perf_caps;
u64 highest_perf, nominal_perf;
int ret;

if (acpi_pstate_strict)
return 0;

ret = cppc_get_perf_caps(cpu, &perf_caps);
if (ret) {
pr_debug("CPU%d: Unable to get performance capabilities (%d)\n",
cpu, ret);
return 0;
pr_debug("CPU%d: Unable to get performance capabilities (%d)\n", cpu, ret);
return;
}

if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD)
highest_perf = amd_get_highest_perf();
*highest_perf = amd_get_highest_perf();
else
highest_perf = perf_caps.highest_perf;
*highest_perf = perf_caps.highest_perf;

nominal_perf = perf_caps.nominal_perf;
*nominal_perf = perf_caps.nominal_perf;
}

static u64 get_max_boost_ratio(unsigned int cpu)
{
u64 highest_perf, nominal_perf;

if (acpi_pstate_strict)
return 0;

cppc_get_highest_nominal_perf(cpu, &highest_perf, &nominal_perf);

if (!highest_perf || !nominal_perf) {
pr_debug("CPU%d: highest or nominal performance missing\n", cpu);
Expand All @@ -663,8 +670,51 @@ static u64 get_max_boost_ratio(unsigned int cpu)

return div_u64(highest_perf << SCHED_CAPACITY_SHIFT, nominal_perf);
}

/* The work item is needed to avoid CPU hotplug locking issues */
static void cpufreq_sched_itmt_work_fn(struct work_struct *work)
{
sched_set_itmt_support();
}

static DECLARE_WORK(sched_itmt_work, cpufreq_sched_itmt_work_fn);

static void cpufreq_set_itmt_prio(int cpu)
{
u64 highest_perf, nominal_perf;
static u64 max_highest_perf = 0, min_highest_perf = U64_MAX;

cppc_get_highest_nominal_perf(cpu, &highest_perf, &nominal_perf);

sched_set_itmt_core_prio(highest_perf, cpu);
cpumask_set_cpu(cpu, &core_prior_mask);

if (max_highest_perf <= min_highest_perf) {
if (highest_perf > max_highest_perf)
max_highest_perf = highest_perf;

if (highest_perf < min_highest_perf)
min_highest_perf = highest_perf;

if (max_highest_perf > min_highest_perf) {
/*
* This code can be run during CPU online under the
* CPU hotplug locks, so sched_set_itmt_support()
* cannot be called from here. Queue up a work item
* to invoke it.
*/
cppc_highest_perf_diff = true;
}
}

if (cppc_highest_perf_diff && cpumask_equal(&core_prior_mask, cpu_online_mask)) {
pr_debug("queue a work to set itmt enabled\n");
schedule_work(&sched_itmt_work);
}
}
#else
static inline u64 get_max_boost_ratio(unsigned int cpu) { return 0; }
static void cpufreq_set_itmt_prio(int cpu) { }
#endif

static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy)
Expand All @@ -677,7 +727,7 @@ static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy)
unsigned int valid_states = 0;
unsigned int result = 0;
u64 max_boost_ratio;
unsigned int i;
unsigned int i, j;
#ifdef CONFIG_SMP
static int blacklisted;
#endif
Expand Down Expand Up @@ -741,6 +791,11 @@ static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy)
pr_info_once("overriding BIOS provided _PSD data\n");
}
#endif
if (c->x86_vendor == X86_VENDOR_CENTAUR || c->x86_vendor == X86_VENDOR_ZHAOXIN) {
for_each_cpu(j, policy->cpus) {
cpufreq_set_itmt_prio(j);
}
}

/* capability check */
if (perf->state_count <= 1) {
Expand Down

0 comments on commit e28f977

Please sign in to comment.