fix: JS API viewports should throw only for basic data issues #6535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Network issues now fire requestfailed events to signal that the table was in a bad state. Fixes DH-18331
niloc132
added
jsapi
NoDocumentationNeeded
ReleaseNotesNeeded
mofojed
approved these changes
Jan 8, 2025
Comment on lines
+253
to
+255
| if (firstRow < 0 || firstRow > lastRow) { | ||
| throw new IllegalArgumentException("Invalid viewport row range: " + firstRow + " to " + lastRow); | ||
| } |
There was a problem hiding this comment.
Guessing you added this because it was in DHE?
There was a problem hiding this comment.
Correct - trying to slightly better match semantics, especially since we removed the check in RangeSet that the ranges are ordered properly (as it was causing performance issues on subscriptions to large tables).
This is one of the few cases where we actually throw when calling setViewport in both APIs. When we get an api design for subscriptions that also handles preview and reverse viewports, we'll be more deliberate about how to handle these classes of errors...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Network issues now fire requestfailed events to signal that the table was in a bad state.
Fixes DH-18331