Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new changes #1307

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

Conversation

Vilmo18
Copy link
Contributor

@Vilmo18 Vilmo18 commented Dec 17, 2024

Very big updates are coming!! (Sorry for some files with differents formatting than the original)

  • Fixing the problem of multiple submissions by updating the condition
  • Adding a new components for visualizing submissions and related submissions (Using the chain mechanism between submissions and some checking for avoiding vulnerability ApplicationForm, ApplicationList and ResponseDetails
  • Addition of new statuses via migrations: Previously, new statuses were added without corresponding database changes. A migration script has now been created to ensure these changes are properly reflected in the database. (With improvement of the scripts based on previous reviews espicially get function)
  • Outcome and response bug fix: Previously, there was one outcome shared across all responses given an event and user. This has been updated so that each response has its own unique outcome. The database structure was modified, migrations were applied, and necessary changes were made to back-end files.
  • Adding new words for traduction
  • Minor bug fixes: Several smaller bugs have been identified and resolved.

@avishkar58
Copy link
Contributor

Hi Yvan! Thanks for the changes.
Just to clarify - is this the same as the previous PR with additional fixes? In that case, please don't raise a new PR, but rather update the existing PR so that I (generally, the reviewer) can see what has changed since the last review. Otherwise I have to start reviewing from scratch which for a big PR like this is a lot of extra work.
Also please can you name your PRs more descriptively, to say what functionality it adds, rather than the generic "add new changes" - thank you very much, and wishing you a Merry Christmas! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants