DESK_REJECT added #1285
Open
DESK_REJECT added #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upaq
reviewed
Oct 8, 2024
api/app/outcome/api.py
Outdated
| event=event, | ||
| user=user, | ||
| ) | ||
| print("event_type::::::::", event.event_type) |
There was a problem hiding this comment.
"print" shouldn't be in the production codebase?
upaq
reviewed
Oct 8, 2024
api/app/outcome/api.py
Outdated
| user=user, | ||
| ) | ||
| print("event_type::::::::", event.event_type) | ||
| print("Type of event.event_type:::::::", type(event.event_type)) |
There was a problem hiding this comment.
"print" shouldn't be in the production codebase?
(please see comments above)
api/app/outcome/api.py
Outdated
| event=event, | ||
| user=user, | ||
| ) | ||
| print("event_type::::::::", event.event_type) |
There was a problem hiding this comment.
"print" shouldn't be in the production codebase?
There was a problem hiding this comment.
Hi @upaq. Thanks for noticing these! Yes, it should not be in the production. I will remove it now.
umair-nasir14
commented
Oct 8, 2024
There was a problem hiding this comment.
Cleaned up. I think there is no other print statement that would go in prod.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A DESK_REJECT status added, primarily for Journal events. To facilitate emails for this status, two new email templates added for journal desk reject and reject. A reason is also propagated to the email for desk_reject and reject, which is propogated through outcome services, therefore a new reason column is added in the outcome table. Finally, all migrations are performed.
Please let me know if there are any changes needed!