Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email admin about journal response #1096

Merged
merged 5 commits into from
Mar 28, 2023

Conversation

shreyalpandit
Copy link
Collaborator

Addresses Issue #1095

Copy link
Contributor

@avishkar58 avishkar58 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick comment I picked up, will leave the full review for @amritpurshotam Thank you!:)

api/app/users/repository.py Outdated Show resolved Hide resolved
api/app/responses/api.py Outdated Show resolved Hide resolved
api/app/events/repository.py Outdated Show resolved Hide resolved
api/app/responses/api.py Outdated Show resolved Hide resolved
api/app/responses/api.py Outdated Show resolved Hide resolved
api/app/responses/api.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@amritpurshotam amritpurshotam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes and sorry for the mix-up with the earlier review comments. I think we should be good after these small updates.

api/app/responses/api.py Outdated Show resolved Hide resolved
api/app/responses/api.py Outdated Show resolved Hide resolved
api/app/responses/api.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@amritpurshotam amritpurshotam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good!

@shreyalpandit shreyalpandit merged commit c72bf41 into remove_dates_cont_journal Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants