fixed scopes getType returning null (#167)

dedoc · Aug 6, 2023 · b3bcbc3 · b3bcbc3
1 parent f6422be
commit b3bcbc3
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 42 deletions.
diff --git a/src/Infer/Scope/Scope.php b/src/Infer/Scope/Scope.php
@@ -38,7 +38,7 @@ public function __construct(
     ) {
     }
 
-    public function getType(Node $node)
+    public function getType(Node $node): Type
     {
         if ($node instanceof Node\Scalar) {
             return (new ScalarTypeGetter)($node);
@@ -113,7 +113,7 @@ public function getType(Node $node)
         if ($node instanceof Node\Expr\PropertyFetch) {
             // Only string prop names support.
             if (! $name = ($node->name->name ?? null)) {
-                return null;
+                return new UnknownType('Cannot infer type of property fetch: not supported yet.');
             }
 
             $calleeType = $this->getType($node->var);
@@ -122,7 +122,7 @@ public function getType(Node $node)
                 // if ($calleeType->is instanceof ObjectType) {
                 //     $calleeType = $calleeType->is;
                 // }
-                return $this->setType($node, new UnknownType("Cannot infer type of property [{$name}] call on template type: not supported yet."));
+                return $this->setType($node, new UnknownType("Cannot infer type of property [{$name}] fetch on template type: not supported yet."));
             }
 
             return $this->setType(

diff --git a/tests/Generator/ResponseExtensionTest.php b/tests/Generator/ResponseExtensionTest.php
diff --git a/tests/Infer/InferTest.php b/tests/Infer/InferTest.php
diff --git a/tests/Infer/Scope/ScopeTest.php b/tests/Infer/Scope/ScopeTest.php
@@ -0,0 +1,13 @@
+<?php
+
+function getStatementTypeForScopeTest(string $statement, array $extensions = [])
+{
+    return analyzeFile('<?php', $extensions)->getExpressionType($statement);
+}
+
+it('infers property fetch nodes types', function ($code, $expectedTypeString) {
+    expect(getStatementTypeForScopeTest($code)->toString())->toBe($expectedTypeString);
+})->with([
+    ['$foo->bar', 'unknown'],
+    ['$foo->bar->{"baz"}', 'unknown'],
+]);