Decouple config loading & log initialization #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jholdstock
changed the title
jholdstock
force-pushed
the
rm-db-log
branch
3 times, most recently
from
d5e569f
to
f11b7e8
Compare
davecgh
reviewed
May 21, 2024
| @@ -425,12 +412,14 @@ func loadConfig() (*vspdConfig, error) { | |||
| } | |||
|
|
|||
| // Create new database. | |||
| err = database.CreateNew(cfg.dbPath, cfg.FeeXPub, cfg.logger(" DB")) | |||
| fmt.Printf("Initializing new database at %s\n", cfg.dbPath) | |||
There was a problem hiding this comment.
Now these won't be in the logs.
| @@ -165,8 +160,6 @@ func CreateNew(dbFile, feeXPub string, log slog.Logger) error { | |||
| return err | |||
| } | |||
|
|
|||
| log.Info("Database initialized") | |||
There was a problem hiding this comment.
This seems like a log you wouldn't want to lose.
There was a problem hiding this comment.
Per #465, creating the database will soon be in a new dedicated binary, so this is somewhat temporary/irrelevant.
This logger did not write any useful information and all errors generated by the func are already returned to the caller for logging.
Loading config and preparing loggers are two separate concepts which should be handled individually. Nesting one inside the other makes little sense and complicates reusing the code.
davecgh
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading config and preparing loggers are two separate concepts which should be handled individually. Nesting one inside the other makes little sense and complicates reusing the code.