Fix invoice status as string

politeiad/backendv2/tstorebe/plugins/cms/cmds.go

@@ -12,7 +12,6 @@ import (
  "fmt"
  "io"
  "sort"
- "strconv"
  "strings"
  "time"
 
@@ -62,7 +61,7 @@ func (c *cmsPlugin) cmdSetInvoiceStatus(token []byte, payload string) (string, e
  }
 
  // Verify signature
- msg := sbs.Token + strconv.FormatUint(uint64(sbs.Status), 10) + sbs.Reason
+ msg := sbs.Token + string(sbs.Status) + sbs.Reason
  err = util.VerifySignature(sbs.Signature, sbs.PublicKey, msg)
  if err != nil {
  return "", convertSignatureError(err)

politeiad/plugins/cms/cms.go

@@ -514,18 +514,18 @@ type InvoiceMetadata struct {
 
 // InvoiceStatusT represents the invoice status of a invoice that has been
 // approved by the Decred stakeholders.
-type InvoiceStatusT uint32
+type InvoiceStatusT string
 
 const (
  // InvoiceStatusInvalid is an invalid invoice status.
- InvoiceStatusInvalid InvoiceStatusT = 0
- InvoiceStatusNotFound InvoiceStatusT = 1 // Invoice not found
- InvoiceStatusNew InvoiceStatusT = 2 // Invoice has not been reviewed
- InvoiceStatusUpdated InvoiceStatusT = 3 // Invoice has unreviewed changes
- InvoiceStatusDisputed InvoiceStatusT = 4 // Invoice has been disputed for some reason
- InvoiceStatusRejected InvoiceStatusT = 5 // Invoice fully rejected and closed
- InvoiceStatusApproved InvoiceStatusT = 6 // Invoice has been approved
- InvoiceStatusPaid InvoiceStatusT = 7 // Invoice has been paid
+ InvoiceStatusInvalid InvoiceStatusT = "invalid"
+ InvoiceStatusNotFound InvoiceStatusT = "not found" // Invoice not found
+ InvoiceStatusNew InvoiceStatusT = "new"  // Invoice has not been reviewed
+ InvoiceStatusUpdated InvoiceStatusT = "updated"  // Invoice has unreviewed changes
+ InvoiceStatusDisputed InvoiceStatusT = "disputed"  // Invoice has been disputed for some reason
+ InvoiceStatusRejected InvoiceStatusT = "rejected"  // Invoice fully rejected and closed
+ InvoiceStatusApproved InvoiceStatusT = "approved"  // Invoice has been approved
+ InvoiceStatusPaid InvoiceStatusT = "paid"  // Invoice has been paid
 )
 
 type LineItemTypeT int

politeiawww/api/cms/v2/v2.go

@@ -274,7 +274,7 @@ type LineItemsInput struct {
  Expenses uint `json:"expenses"` // Total cost (in USD cents) of line item (if expense or misc)
 }
 
-type InvoiceStatusT int
+type InvoiceStatusT uint32
 
 const (
  // Invoice status codes