Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pool: Consolidate waitgroup logic. #373

Merged
merged 1 commit into from
Sep 16, 2023

Conversation

davecgh
Copy link
Member

@davecgh davecgh commented Sep 15, 2023

This switches client, hub, endpoint over to use the new pattern that consolidates the waitgroup logic in a single location.

This pattern is easier to reason about and less error prone since it's trivial to see at a glance that the calls to Done are happening as intended versus having to chase them down all over the code.

@davecgh davecgh force-pushed the pool_consolidate_waitgroup branch 2 times, most recently from 43304ef to 69839c5 Compare September 16, 2023 00:31
This switches client, hub, endpoint over to use the new pattern that
consolidates the waitgroup logic in a single location.

This pattern is easier to reason about and less error prone since it's
trivial to see at a glance that the calls to Done are happening as
intended versus having to chase them down all over the code.
@davecgh davecgh force-pushed the pool_consolidate_waitgroup branch from 69839c5 to 1bcf94c Compare September 16, 2023 00:34
Copy link
Member

@jholdstock jholdstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Massive improvement.

@jholdstock jholdstock merged commit e193be6 into decred:master Sep 16, 2023
2 checks passed
@davecgh davecgh deleted the pool_consolidate_waitgroup branch September 16, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants