blockchain: Refactor to use new chain view. #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
blockchain_use_chainview
branch
2 times, most recently
from
c0b3429
to
60361d0
Compare
|
No issues encountered running on testnet. |
davecgh
force-pushed
the
blockchain_use_chainview
branch
from
60361d0
to
912fbd0
Compare
|
Been running smooth on testnet for a while now |
|
Ran for 5 days with no problems on testnet and mainnet. |
alexlyp
approved these changes
Jul 20, 2018
jrick
approved these changes
Jul 20, 2018
This refactors and simplifies the code in blockchain to use the new more
efficient chain views.
An overview of the logic changes are as follows:
- Remove inMainChain from block nodes since that can now be efficiently
determined by using the chain view
- Track the best chain via a chain view instead of a single block node
- Use the tip of the best chain view everywhere bestNode was used
- Update chain view tip instead of updating best node
- Remove height map and associated lock in favor of chain view
- Use chain view NodeByHeight everywhere height map was used
- Change reorg logic to use more efficient chain view fork finding logic
- Change block locator code over to use more efficient chain view logic
- Remove now unused block-index-based block locator code
- Move BlockLocator definition to chain.go
- Move BlockLocatorFromHash and LatestBlockLocator to chain.go
- Update both to use more efficient chain view logic
- Rework several functions to use chain view for main chain detection
- fetchMainChainBlockByNode
- BlockByHeight
- MainChainHasBlock
- findPreviousCheckpoint
- IsCheckpointCandidate
davecgh
force-pushed
the
blockchain_use_chainview
branch
from
912fbd0
to
9ef7db9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires #1338.
This refactors and simplifies the code in blockchain to use the new more efficient chain views.
An overview of the logic changes are as follows:
inMainChainfrom block nodes since that can now be efficiently determined by using the chain viewbestNodewas usedNodeByHeighteverywhere height map was usedBlockLocatordefinition tochain.goBlockLocatorFromHashandLatestBlockLocatortochain.gofetchMainChainBlockByNodeBlockByHeightMainChainHasBlockfindPreviousCheckpointIsCheckpointCandidateThis is work towards #1145.