Scratch Comments Feature #1230
Draft
Scratch Comments Feature #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added refined textarea * Added delete and edit comments
bates64
requested changes
May 28, 2024
| @@ -0,0 +1,78 @@ | |||
| .holder { | |||
There was a problem hiding this comment.
New code should use Tailwind where possible rather than SCSS modules
| overflow: hidden; | ||
| resize: none; | ||
|
|
||
| &::-webkit-input-placeholder { |
There was a problem hiding this comment.
This is outdated https://caniuse.com/css-placeholder
| } | ||
| } | ||
|
|
||
| function EditComment({ comment, stopEditing, submit }: { comment: any, stopEditing: () => void, submit: (text: string) => Promise<unknown> }) { |
There was a problem hiding this comment.
unknown!?
Also split this signature onto multiple lines
Comment on lines
+27
to
+30
| await api.delete_(commentUrl(comment), {}) | ||
| alert("Comment deleted") | ||
| } catch (e) { | ||
| alert(`Error Deleting Comment: ${e}`) |
There was a problem hiding this comment.
TODO this should be a dialog or a toast or something
| <div className={styles.counter}>{text.length} / {maxTextLength}</div> | ||
| </div> | ||
| </section> | ||
| <br /> |
| } | ||
|
|
||
| return ( | ||
| <div> |
There was a problem hiding this comment.
Ideally this would be more semantic, like a form, and editing would submit the form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feedback is welcome
Features
Tests
Comment
Most recent example
Screencast.from.2024-05-16.00-03-08.webm
fixes #128