Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(e2e): label and annotation #7

Merged
merged 12 commits into from
Mar 20, 2024
Merged

feat(e2e): label and annotation #7

merged 12 commits into from
Mar 20, 2024

Conversation

universal-itengineer
Copy link
Member

@universal-itengineer universal-itengineer commented Feb 8, 2024 •
edited
Loading

Description

Add e2e tests to check label and annotation on resources (pod, vm, vmi, etc.)

Why do we need it, and what problem does it solve?

It is a part of task for automate e2e tests

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@universal-itengineer universal-itengineer marked this pull request as draft February 8, 2024 12:11
@universal-itengineer universal-itengineer force-pushed the feat/e2e-test/label-annotation branch 2 times, most recently from fae7f8a to 57844c7 Compare February 8, 2024 12:50
@universal-itengineer universal-itengineer self-assigned this Feb 8, 2024
@universal-itengineer universal-itengineer marked this pull request as ready for review February 8, 2024 16:56
@universal-itengineer universal-itengineer changed the title chore: test for label and annotation e2e test: label and annotation Feb 9, 2024
@fl64 fl64 changed the title e2e test: label and annotation chore(e2e): label and annotation Feb 9, 2024
yaroslavborbat
yaroslavborbat requested changes Feb 26, 2024
View reviewed changes
tests/e2e/kubectl/resource.go Outdated Show resolved Hide resolved
@universal-itengineer universal-itengineer force-pushed the feat/e2e-test/label-annotation branch from c73c791 to d58b743 Compare February 27, 2024 22:10
yaroslavborbat
yaroslavborbat requested changes Feb 28, 2024
View reviewed changes
tests/e2e/vm_label_annotation_test.go Outdated Show resolved Hide resolved
tests/e2e/vm_label_annotation_test.go Outdated Show resolved Hide resolved
tests/e2e/vm_label_annotation_test.go Outdated Show resolved Hide resolved
tests/e2e/vm_label_annotation_test.go Outdated Show resolved Hide resolved
tests/e2e/vm_label_annotation_test.go Outdated Show resolved Hide resolved
@universal-itengineer universal-itengineer force-pushed the feat/e2e-test/label-annotation branch from d53b724 to dd8b7ad Compare February 28, 2024 21:25
@universal-itengineer universal-itengineer force-pushed the feat/e2e-test/label-annotation branch 5 times, most recently from e8f8b50 to 4c508f0 Compare March 4, 2024 13:08
@universal-itengineer universal-itengineer force-pushed the feat/e2e-test/label-annotation branch 4 times, most recently from ad692d8 to a296cc5 Compare March 4, 2024 21:00
@universal-itengineer
chore: resovle conflict
56097a5 
Signed-off-by: Nikita Korolev <[email protected]>
@universal-itengineer
chore: test for label and annotation
68dbac8 
Signed-off-by: Nikita Korolev <[email protected]>
@universal-itengineer
chore: add file with tests
4eb93d9 
Signed-off-by: Nikita Korolev <[email protected]>

chore: fix file name

Signed-off-by: Nikita Korolev <[email protected]>
@universal-itengineer
chore: taskfile add task with predefined vars and run one test (ginkg…
79e394c 
…o --focus)

Signed-off-by: Nikita Korolev <[email protected]>
@universal-itengineer
fix: task run_one and var
253ddd4 
Signed-off-by: Nikita Korolev <[email protected]>
@universal-itengineer
chore: fix test condition
e3df7eb 
Signed-off-by: Nikita Korolev <[email protected]>
@universal-itengineer
chore: refactor tests
749ee79 
Signed-off-by: Nikita Korolev <[email protected]>

chore: remove unnecessary constraints

Signed-off-by: Nikita Korolev <[email protected]>

chore: refactor tests

Signed-off-by: Nikita Korolev <[email protected]>
@universal-itengineer
chore: add handling errors
18b9cc0 
Signed-off-by: Nikita Korolev <[email protected]>

chore: add handling errors

Signed-off-by: Nikita Korolev <[email protected]>

chore: update getPodName

Signed-off-by: Nikita Korolev <[email protected]>
@universal-itengineer universal-itengineer force-pushed the feat/e2e-test/label-annotation branch from 40b9f32 to 18b9cc0 Compare March 4, 2024 21:11
@universal-itengineer
chore: fixing comments
d5080dd 
Signed-off-by: Nikita Korolev <[email protected]>
@universal-itengineer universal-itengineer force-pushed the feat/e2e-test/label-annotation branch from ede123a to d5080dd Compare March 6, 2024 15:09
yaroslavborbat
yaroslavborbat requested changes Mar 11, 2024
View reviewed changes
tests/e2e/vm_label_annotation_test.go Outdated Show resolved Hide resolved
tests/e2e/vm_label_annotation_test.go Outdated Show resolved Hide resolved
@universal-itengineer universal-itengineer changed the title chore(e2e): label and annotation feat(e2e): label and annotation Mar 19, 2024
@universal-itengineer
chore: resolve comments
115b7a0 
Signed-off-by: Nikita Korolev <[email protected]>
@universal-itengineer universal-itengineer merged commit 1207c4b into main Mar 20, 2024
1 check passed
universal-itengineer added a commit that referenced this pull request Mar 20, 2024
@universal-itengineer
feat(e2e): label and annotation (#7)
e29ab63 
feat(e2e):  add label and annotation tests

---------
Signed-off-by: Nikita Korolev <[email protected]>
This was referenced May 7, 2024
Closed
Merged
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Aug 2, 2024
Merged
fl64 added a commit that referenced this pull request Aug 14, 2024
@fl64
docs: follow rrpo requirements #7
1a1fb3f
fl64 added a commit that referenced this pull request Aug 14, 2024
@fl64
docs: follow rrpo requirements #7
e23bbe7 
Signed-off-by: Pavel Tishkov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diafour diafour diafour approved these changes

@yaroslavborbat yaroslavborbat yaroslavborbat approved these changes

Assignees

@universal-itengineer universal-itengineer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@universal-itengineer @diafour @yaroslavborbat