Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(vm): split sync internal vm and power state on different handlers #558

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor(vm): split sync internal vm and power state on different handlers #558

wants to merge 2 commits into from
+217 −141

Conversation

LopatinDmitr
Copy link
Contributor

@LopatinDmitr LopatinDmitr commented Dec 5, 2024 •
edited
Loading

Description

  • This PR separates the synchronization of internal virtual machine and power state management into distinct handlers
  • This PR moves RunPolicy: AlwaysOn/AlwaysOff control logic from KubeVirt to vm controller.

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@LopatinDmitr LopatinDmitr force-pushed the fix/vm/split-sync-kvvm-and-power-state branch 2 times, most recently from cee0143 to ee689aa Compare December 5, 2024 22:01
@LopatinDmitr LopatinDmitr changed the title fix(vm): split sync kvvm and power state fix(vm): split sync kvvm and power state on different handlers Dec 6, 2024
@LopatinDmitr LopatinDmitr marked this pull request as ready for review December 6, 2024 11:56
@LopatinDmitr LopatinDmitr force-pushed the fix/vm/split-sync-kvvm-and-power-state branch 8 times, most recently from 64faedd to c9ec879 Compare December 9, 2024 18:33
@LopatinDmitr
fix
01d4cb6 
Signed-off-by: dmitry.lopatin <[email protected]>
@LopatinDmitr LopatinDmitr force-pushed the fix/vm/split-sync-kvvm-and-power-state branch 9 times, most recently from 8192fcb to faa5d8d Compare December 13, 2024 11:58
@LopatinDmitr
++
098f885 
Signed-off-by: dmitry.lopatin <[email protected]>
@LopatinDmitr LopatinDmitr force-pushed the fix/vm/split-sync-kvvm-and-power-state branch from faa5d8d to 098f885 Compare December 13, 2024 11:59
@LopatinDmitr LopatinDmitr changed the title fix(vm): split sync kvvm and power state on different handlers refactor(vm): split sync kvvm and power state on different handlers Dec 13, 2024
@LopatinDmitr LopatinDmitr changed the title refactor(vm): split sync kvvm and power state on different handlers refactor(vm): split sync internal vm and power state on different handlers Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaroslavborbat yaroslavborbat Awaiting requested review from yaroslavborbat

At least 1 approving review is required to merge this pull request.

Assignees

@LopatinDmitr LopatinDmitr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@LopatinDmitr