Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vm): remove restartID and spec.restartApprovalID #27

Merged
merged 6 commits into from
Mar 29, 2024
Merged

fix(vm): remove restartID and spec.restartApprovalID #27

merged 6 commits into from
Mar 29, 2024

Conversation

diafour
Copy link
Member

@diafour diafour commented Mar 20, 2024

Description

Remove status.restartID and spec.restartApprovalID. restartAwaitingChanges are cleared on VM restart.

Why do we need it, and what problem does it solve?

Redundant legacy mechanism after merging #3

What is the expected result?

  • status.restartID and spec.restartApprovalID are gone.
  • status.restartAwaitingChanges are cleared on VM restart, either with VMOP or from inside the VM.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@diafour diafour marked this pull request as draft March 20, 2024 15:20
@diafour diafour force-pushed the chore/remove_restart_approval_id branch from b7ba969 to a0125e1 Compare March 21, 2024 09:27
@diafour diafour force-pushed the chore/remove_restart_approval_id branch 3 times, most recently from cc321d8 to dc48321 Compare March 22, 2024 15:52
@diafour diafour marked this pull request as ready for review March 25, 2024 07:58
Isteb4k
Isteb4k requested changes Mar 25, 2024
View reviewed changes
crds/virtualmachine.yaml Outdated Show resolved Hide resolved
images/virtualization-artifact/pkg/controller/vm_reconciler.go Outdated Show resolved Hide resolved
images/virtualization-artifact/pkg/controller/vm_reconciler.go Outdated Show resolved Hide resolved
Isteb4k
Isteb4k reviewed Mar 25, 2024
View reviewed changes
Copy link
Contributor

@Isteb4k Isteb4k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter and tests are failed

@diafour
Copy link
Member Author

diafour commented Mar 25, 2024

Ouch, I've accidentally convert this PR to ready =))

@diafour diafour marked this pull request as draft March 25, 2024 18:22
@Isteb4k Isteb4k self-requested a review March 29, 2024 08:35
@Isteb4k Isteb4k marked this pull request as ready for review March 29, 2024 08:35
@Isteb4k Isteb4k force-pushed the chore/remove_restart_approval_id branch from adafc90 to 47511e6 Compare March 29, 2024 12:53
@Isteb4k Isteb4k merged commit b9c0c4d into main Mar 29, 2024
1 check passed
This was referenced May 7, 2024
Closed
Merged
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Aug 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Isteb4k Isteb4k Isteb4k approved these changes

Assignees

@diafour diafour

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diafour @Isteb4k