Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): moved virtualization api structs to separated go mod #20

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

Isteb4k
Copy link
Contributor

@Isteb4k Isteb4k commented Mar 6, 2024

Description

Moved virtualization api to separated go module

Why do we need it, and what problem does it solve?

It is necessary to be able to import only api entities into other projects without the virtualization controller internals

What is the expected result?

New go module

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@Isteb4k Isteb4k force-pushed the feat/separate-virtualization-api branch from 617c5b4 to 6c4078d Compare March 6, 2024 10:35
@Isteb4k Isteb4k marked this pull request as ready for review March 6, 2024 10:35
@Isteb4k Isteb4k marked this pull request as draft March 13, 2024 11:41
@Isteb4k Isteb4k self-assigned this Mar 14, 2024
@Isteb4k Isteb4k force-pushed the feat/separate-virtualization-api branch 2 times, most recently from 5669336 to 07899d2 Compare March 20, 2024 09:28
api/scripts/update-codegen.sh Outdated Show resolved Hide resolved
@Isteb4k Isteb4k force-pushed the feat/separate-virtualization-api branch from 07899d2 to 7006fa6 Compare March 21, 2024 08:53
@Isteb4k Isteb4k force-pushed the feat/separate-virtualization-api branch from 7006fa6 to 118bb9c Compare March 21, 2024 08:55
@Isteb4k Isteb4k marked this pull request as ready for review March 21, 2024 08:55
@Isteb4k Isteb4k force-pushed the feat/separate-virtualization-api branch from 008d280 to 271c438 Compare March 21, 2024 09:19
Copy link
Member

@diafour diafour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add replace.

@Isteb4k Isteb4k force-pushed the feat/separate-virtualization-api branch from 271c438 to 32c30ee Compare March 21, 2024 11:46
@Isteb4k Isteb4k force-pushed the feat/separate-virtualization-api branch from 32c30ee to 588fe28 Compare March 21, 2024 11:50
@Isteb4k Isteb4k merged commit 215299c into main Mar 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants