feat(vmbda): apply new controller design #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isteb4k
changed the title
Isteb4k
force-pushed
the
fix/vmbda/hotplug-api-call
branch
3 times, most recently
from
ffef406 to
4db6f65
Compare
Isteb4k
force-pushed
the
feat/vmbda/apply-new-design
branch
5 times, most recently
from
38e2b46 to
b22db86
Compare
Isteb4k
force-pushed
the
fix/vmbda/hotplug-api-call
branch
from
4db6f65 to
6ad3e77
Compare
Isteb4k
force-pushed
the
feat/vmbda/apply-new-design
branch
2 times, most recently
from
a73e005 to
c69f753
Compare
Isteb4k
force-pushed
the
fix/vmbda/hotplug-api-call
branch
2 times, most recently
from
7fd16ee to
e1d197d
Compare
Isteb4k
force-pushed
the
feat/vmbda/apply-new-design
branch
3 times, most recently
from
a264b6d to
44e216b
Compare
Isteb4k
force-pushed
the
fix/vmbda/hotplug-api-call
branch
from
e1d197d to
3198fc0
Compare
Isteb4k
force-pushed
the
feat/vmbda/apply-new-design
branch
8 times, most recently
from
a27b6ba to
21e347e
Compare
Isteb4k
force-pushed
the
fix/vmbda/hotplug-api-call
branch
from
3198fc0 to
efeed43
Compare
Isteb4k
force-pushed
the
feat/vmbda/apply-new-design
branch
from
21e347e to
64b19d1
Compare
yaroslavborbat
requested changes
Jul 4, 2024
images/virtualization-artifact/pkg/controller/kvbuilder/kvvm_utils.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/service/attachment_service.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vmbda/internal/deletion.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vmbda/internal/deletion.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vmbda/vmbda_webhook.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vm/internal/block_device.go
Outdated
Show resolved
Hide resolved
Isteb4k
force-pushed
the
feat/vmbda/apply-new-design
branch
from
ed7ea5d to
8cbdbc0
Compare
diafour
reviewed
Jul 4, 2024
diafour
reviewed
Jul 4, 2024
images/virtualization-artifact/pkg/controller/service/resource.go
Outdated
Show resolved
Hide resolved
diafour
reviewed
Jul 4, 2024
images/virtualization-artifact/pkg/controller/vmbda/internal/watcher/vmbda_watcher.go
Outdated
Show resolved
Hide resolved
diafour
reviewed
Jul 4, 2024
images/virtualization-artifact/pkg/controller/vmbda/internal/block_device_ready.go
Outdated
Show resolved
Hide resolved
Isteb4k
force-pushed
the
feat/vmbda/apply-new-design
branch
from
8cbdbc0 to
41ad78f
Compare
Isteb4k
force-pushed
the
fix/vmbda/hotplug-api-call
branch
from
4f69e1a to
bb3842a
Compare
Isteb4k
force-pushed
the
feat/vmbda/apply-new-design
branch
2 times, most recently
from
cb91732 to
1985fb1
Compare
Isteb4k
force-pushed
the
fix/vmbda/hotplug-api-call
branch
from
bb3842a to
67bea87
Compare
Isteb4k
force-pushed
the
feat/vmbda/apply-new-design
branch
from
1985fb1 to
02e8c92
Compare
Isteb4k
force-pushed
the
fix/vmbda/hotplug-api-call
branch
from
67bea87 to
e109e1b
Compare
Isteb4k
force-pushed
the
feat/vmbda/apply-new-design
branch
2 times, most recently
from
ee9a9b5 to
1dbf6d3
Compare
Isteb4k
force-pushed
the
fix/vmbda/hotplug-api-call
branch
from
e109e1b to
0a6d145
Compare
Isteb4k
force-pushed
the
feat/vmbda/apply-new-design
branch
from
1dbf6d3 to
0b47c76
Compare
Isteb4k
force-pushed
the
fix/vmbda/hotplug-api-call
branch
from
0a6d145 to
c302c5c
Compare
Isteb4k
force-pushed
the
feat/vmbda/apply-new-design
branch
from
0b47c76 to
1b3b1d2
Compare
yaroslavborbat
previously approved these changes
Jul 5, 2024
Signed-off-by: Isteb4k <[email protected]>
Signed-off-by: Isteb4k <[email protected]>
Isteb4k
force-pushed
the
feat/vmbda/apply-new-design
branch
from
1b3b1d2 to
557f271
Compare
yaroslavborbat
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist