fix(vmbda): fix hotplug api call #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isteb4k
force-pushed
the
fix/vmbda/hotplug-api-call
branch
2 times, most recently
from
8932bf9 to
7773720
Compare
Isteb4k
force-pushed
the
feat/vd/apply-new-design
branch
from
8265e04 to
995b937
Compare
Isteb4k
force-pushed
the
fix/vmbda/hotplug-api-call
branch
4 times, most recently
from
0464fde to
15192fb
Compare
Isteb4k
force-pushed
the
feat/vd/apply-new-design
branch
from
995b937 to
1a36f22
Compare
Isteb4k
force-pushed
the
fix/vmbda/hotplug-api-call
branch
5 times, most recently
from
c6b03cc to
76ffe0d
Compare
Isteb4k
force-pushed
the
feat/vd/apply-new-design
branch
from
bc83836 to
035882b
Compare
Isteb4k
force-pushed
the
fix/vmbda/hotplug-api-call
branch
9 times, most recently
from
7193d5f to
3929e96
Compare
Isteb4k
force-pushed
the
feat/vd/apply-new-design
branch
3 times, most recently
from
f55189e to
93938af
Compare
Isteb4k
force-pushed
the
fix/vmbda/hotplug-api-call
branch
2 times, most recently
from
fd7f0c3 to
ffef406
Compare
Isteb4k
force-pushed
the
fix/vmbda/hotplug-api-call
branch
6 times, most recently
from
3198fc0 to
efeed43
Compare
Isteb4k
force-pushed
the
fix/vmbda/hotplug-api-call
branch
from
efeed43 to
e488fe8
Compare
yaroslavborbat
requested changes
Jul 4, 2024
images/virtualization-artifact/pkg/apiserver/registry/vm/rest/remove_volume.go
Show resolved
Hide resolved
diafour
reviewed
Jul 4, 2024
Isteb4k
force-pushed
the
fix/vmbda/hotplug-api-call
branch
4 times, most recently
from
e109e1b to
0a6d145
Compare
Signed-off-by: Isteb4k <[email protected]>
Signed-off-by: Isteb4k <[email protected]>
Isteb4k
force-pushed
the
fix/vmbda/hotplug-api-call
branch
from
0a6d145 to
c302c5c
Compare
yaroslavborbat
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, during the hot plugging process, virt-controller communicated with virt-api through the KubeVirt API service. However, since this API service was removed, the hot plugging process stopped working.
No new finalizers can be added if the object is being deleted).Checklist