Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dev): add tasks to ease creating patches #132

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

diafour
Copy link
Member

@diafour diafour commented Jun 14, 2024

Description

Add patch helper script to automate some operations described in docs/internal/cdi_kubevirt_patching.md:

  • task patch:new to start working on a new patch on top of existing patches
  • task patch:edit to change an existing patch on top of previous patches

Why do we need it, and what problem does it solve?

Manualy applying patches is boring.

What is the expected result?

I can run just one command to start working on a new patch.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

- task patch:new to start working on a new patch on top of existing patches
- task patch:edit to change an existing patch on top of previous patches

Signed-off-by: Ivan Mikheykin <[email protected]>
@diafour diafour requested a review from yaroslavborbat June 14, 2024 06:18
@diafour diafour added the validation/skip/doc_changes Skip doc changes validation label Jun 15, 2024
hack/patch_helper.sh Outdated Show resolved Hide resolved
++ do no stage changes for "stop-at" patch

Signed-off-by: Ivan Mikheykin <[email protected]>
@diafour diafour merged commit 5013b48 into main Jun 26, 2024
1 check passed
@diafour diafour deleted the refactor/dev/patch_helper branch June 26, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation/skip/doc_changes Skip doc changes validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants