fix(crd): increasing the grace period for virtual machine shutdown #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavel Tishkov <[email protected]>
fl64
force-pushed
the
fix/termination-grace-period
branch
from
b13f37d to
8d7806e
Compare
yaroslavborbat
approved these changes
Feb 20, 2024
diafour
approved these changes
Feb 20, 2024
This was referenced May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set the termination grace period for virtual machine to 1 hour
Why do we need it, and what problem does it solve?
The normal shutdown of a VM can take a long time. 1 hour is chosen as a compromise default setting.
What is the expected result?
Checklist