refactor(kube-api-rewriter): last changes to labels rewriter #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diafour
changed the title
diafour
force-pushed
the
refactor/kube-api-rewriter/rewrite-labels-annos-fins-test
branch
2 times, most recently
from
aea440e to
3632a87
Compare
diafour
force-pushed
the
refactor/kube-api-rewriter/rewrite-labels-annos-fins-test
branch
3 times, most recently
from
66e945b to
986057d
Compare
diafour
changed the title
yaroslavborbat
force-pushed
the
feat/proxy/rewrite-labels-annos
branch
from
409fa21 to
e7d5e4c
Compare
diafour
force-pushed
the
feat/proxy/rewrite-labels-annos
branch
from
e7d5e4c to
64be663
Compare
diafour
force-pushed
the
refactor/kube-api-rewriter/rewrite-labels-annos-fins-test
branch
from
986057d to
9a24b12
Compare
diafour
force-pushed
the
feat/proxy/rewrite-labels-annos
branch
from
97fa649 to
6bd3bae
Compare
diafour
force-pushed
the
refactor/kube-api-rewriter/rewrite-labels-annos-fins-test
branch
from
9a24b12 to
eaeabc3
Compare
- Add KubeVirt and CDI rules for labels, annotations and finalizers. - Add rewriter for labelSelector in queries. - Add rewriters for affinity, labelSelectors in different resources. - Add metadata patch rewriters: nodes, services, deployments, ds, ... - Add webhooks patch rewriters: validatingwebhookconfigurations, mutatingwebhookconfigurations - Add more resources for rewrite: jobs, services, deployments, sts, ds, pvc, pod, ... - Enable rewrite for 3rd party resources: servicemonitors, prometheusrules, ... - Rename labels in our templates. Add kubectl.kubernetes.io/default-container annotation. - Add virt-operator patch to rename install-strategy labels: there is no way to rewrite these labels with kube-api-rewriter. - Simplify some Rewrite* methods using transformers - Create PrefixedNameRewriter to hold original-renamed indexes. Signed-off-by: Ivan Mikheykin <[email protected]>
diafour
force-pushed
the
refactor/kube-api-rewriter/rewrite-labels-annos-fins-test
branch
from
eaeabc3 to
05da3c9
Compare
yaroslavborbat
approved these changes
Jun 17, 2024
Signed-off-by: Ivan Mikheykin <[email protected]>
diafour
deleted the
refactor/kube-api-rewriter/rewrite-labels-annos-fins-test
branch
diafour
added a commit
that referenced
this pull request
Jun 19, 2024
- Add KubeVirt and CDI rules for labels, annotations and finalizers. - Add rewriter for labelSelector in queries. - Add rewriters for affinity, labelSelectors in different resources. - Add metadata patch rewriters: nodes, services, deployments, ds, ... - Add webhooks patch rewriters: validatingwebhookconfigurations, mutatingwebhookconfigurations - Add more resources for rewrite: jobs, services, deployments, sts, ds, pvc, pod, ... - Enable rewrite for 3rd party resources: servicemonitors, prometheusrules, ... - Rename labels in our templates. Add kubectl.kubernetes.io/default-container annotation. - Add virt-operator patch to rename install-strategy labels: there is no way to rewrite these labels with kube-api-rewriter. - Simplify some Rewrite* methods using transformers - Create PrefixedNameRewriter to hold original-renamed indexes. --------- Signed-off-by: Ivan Mikheykin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Why do we need it, and what problem does it solve?
What is the expected result?
Checklist