-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cvi): apply new controller design #111
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isteb4k
force-pushed
the
feat/cvi/apply-new-design
branch
22 times, most recently
from
June 3, 2024 11:01
1ade4cf
to
916fb74
Compare
Isteb4k
force-pushed
the
feat/cvi/apply-new-design
branch
6 times, most recently
from
June 3, 2024 13:15
051c186
to
f6b7ed5
Compare
Isteb4k
force-pushed
the
feat/cvi/apply-new-design
branch
from
June 9, 2024 19:01
f6b7ed5
to
ed78d5f
Compare
Isteb4k
force-pushed
the
feat/cvi/apply-new-design
branch
3 times, most recently
from
June 20, 2024 15:38
b4ae20c
to
77933a0
Compare
diafour
requested changes
Jun 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments
images/virtualization-artifact/pkg/controller/cvi/cvi_webhook.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/cvi/internal/source/errors.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/cvi/internal/deletion.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/service/uploader_service.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/cvi/internal/source/sources.go
Outdated
Show resolved
Hide resolved
Isteb4k
force-pushed
the
feat/cvi/apply-new-design
branch
from
June 21, 2024 07:41
9b7c0b7
to
7fabb70
Compare
yaroslavborbat
approved these changes
Jun 21, 2024
Signed-off-by: Isteb4k <[email protected]>
Signed-off-by: Isteb4k <[email protected]>
Isteb4k
force-pushed
the
feat/cvi/apply-new-design
branch
from
June 25, 2024 11:38
7fabb70
to
62f1ed6
Compare
diafour
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apply new CVI controller design
! The VD controller is disabled
Checklist