Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(virtualization-api): first implementation #11

Merged
merged 38 commits into from
Mar 14, 2024
Merged

feat(virtualization-api): first implementation #11

merged 38 commits into from
Mar 14, 2024

Conversation

yaroslavborbat
Copy link
Member

@yaroslavborbat yaroslavborbat commented Feb 14, 2024 •
edited
Loading

Description

Added a new component virtualization-api - extension API server.

Why do we need it, and what problem does it solve?

Using the api server, we can connect to virtual machines and perform various operations. Currently implemented: console, vnc, port forwarding

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@yaroslavborbat yaroslavborbat self-assigned this Feb 14, 2024
@yaroslavborbat yaroslavborbat marked this pull request as draft February 14, 2024 08:28
@yaroslavborbat yaroslavborbat force-pushed the feat/virtualization-api branch 2 times, most recently from 2654dcd to 6a104b8 Compare February 21, 2024 16:09
@yaroslavborbat yaroslavborbat force-pushed the feat/virtualization-api branch 4 times, most recently from 1832a1e to 7e19bd4 Compare March 4, 2024 14:55
@yaroslavborbat
init apiserver
c8328fd 
Signed-off-by: Yaroslav Borbat <[email protected]>
@yaroslavborbat
impl
f927ca2 
Signed-off-by: Yaroslav Borbat <[email protected]>
@yaroslavborbat
fix
374086c 
Signed-off-by: Yaroslav Borbat <[email protected]>
@yaroslavborbat
impl
8305da4 
Signed-off-by: Yaroslav Borbat <[email protected]>
@yaroslavborbat
fix lint
2c75483 
Signed-off-by: Yaroslav Borbat <[email protected]>
@yaroslavborbat
fix
9f05009 
Signed-off-by: Yaroslav Borbat <[email protected]>
@yaroslavborbat
fix
2c7a240 
Signed-off-by: Yaroslav Borbat <[email protected]>
@yaroslavborbat
impl
8da354b 
Signed-off-by: Yaroslav Borbat <[email protected]>
@yaroslavborbat
fix
cea85ea 
Signed-off-by: Yaroslav Borbat <[email protected]>
@yaroslavborbat
fix
b2a7058 
Signed-off-by: Yaroslav Borbat <[email protected]>
@yaroslavborbat
add rbac
306eacd 
Signed-off-by: Yaroslav Borbat <[email protected]>
@yaroslavborbat
rename api secret
8368ca6 
Signed-off-by: Yaroslav Borbat <[email protected]>
@yaroslavborbat
+
d1682d5 
Signed-off-by: Yaroslav Borbat <[email protected]>
@yaroslavborbat
add
8c4abe7 
Signed-off-by: Yaroslav Borbat <[email protected]>
@yaroslavborbat
fix
acacafd 
Signed-off-by: Yaroslav Borbat <[email protected]>
@yaroslavborbat
fix
f5b95be 
Signed-off-by: Yaroslav Borbat <[email protected]>
@yaroslavborbat
add
baafd2d 
Signed-off-by: Yaroslav Borbat <[email protected]>
@yaroslavborbat
add
2a5ddf7 
Signed-off-by: Yaroslav Borbat <[email protected]>
@yaroslavborbat
add
ba0d275 
Signed-off-by: Yaroslav Borbat <[email protected]>
@yaroslavborbat
fix
415bdfb 
Signed-off-by: Yaroslav Borbat <[email protected]>
@yaroslavborbat yaroslavborbat force-pushed the feat/virtualization-api branch from 7e19bd4 to 415bdfb Compare March 5, 2024 07:06
@yaroslavborbat
fix lint
15fae64 
Signed-off-by: Yaroslav Borbat <[email protected]>
@yaroslavborbat
add
15f2126 
Signed-off-by: Yaroslav Borbat <[email protected]>
@yaroslavborbat
+
a4847e0 
Signed-off-by: Yaroslav Borbat <[email protected]>
@yaroslavborbat
fix
d6a2287 
Signed-off-by: Yaroslav Borbat <[email protected]>
@yaroslavborbat
+
57afc05 
Signed-off-by: Yaroslav Borbat <[email protected]>
@yaroslavborbat yaroslavborbat changed the title feat: add virtualization-api feat(virtualization-api): first implementations Mar 11, 2024
@yaroslavborbat yaroslavborbat changed the title feat(virtualization-api): first implementations feat(virtualization-api): first implementation Mar 11, 2024
@yaroslavborbat yaroslavborbat marked this pull request as ready for review March 11, 2024 18:11
@Isteb4k Isteb4k requested review from diafour and removed request for diafour March 12, 2024 09:07
Isteb4k
Isteb4k requested changes Mar 13, 2024
View reviewed changes
images/virtualization-artifact/Taskfile.dist.yaml Outdated Show resolved Hide resolved
images/virtualization-artifact/pkg/tls/util/util.go Outdated Show resolved Hide resolved
images/virtualization-artifact/pkg/tls/util/util.go Outdated Show resolved Hide resolved
images/virtualization-artifact/pkg/tls/certManager/filesystem/file-cert-manager.go Outdated Show resolved Hide resolved
images/virtualization-artifact/pkg/tls/certManager/filesystem/file-cert-manager.go Outdated Show resolved Hide resolved
images/virtualization-artifact/pkg/apiserver/registry/vm/rest/stream.go Show resolved Hide resolved
images/virtualization-artifact/cmd/virtualization-api/app/start.go Show resolved Hide resolved
images/virtualization-artifact/cmd/virtualization-api/app/start.go Outdated Show resolved Hide resolved
images/virtualization-artifact/cmd/virtualization-api/app/options/options.go Outdated Show resolved Hide resolved
images/virtualization-artifact/api/client/kubecli/websocket.go Show resolved Hide resolved
@yaroslavborbat
resolve comments
ee3ee7a 
Signed-off-by: Yaroslav Borbat <[email protected]>
@yaroslavborbat yaroslavborbat requested a review from Isteb4k March 13, 2024 15:25
@yaroslavborbat
resolve commits
c576b79 
Signed-off-by: Yaroslav Borbat <[email protected]>
yaroslavborbat and others added 4 commits March 14, 2024 12:38
@yaroslavborbat @diafour
Update images/virtualization-artifact/api/core/register.go
1a33f7c 
Co-authored-by: Ivan Mikheykin <[email protected]>
Signed-off-by: Yaroslav Borbat <[email protected]>
@yaroslavborbat @diafour
Update hooks/lib/certificate/parse.py
4ae0fa6 
Co-authored-by: Ivan Mikheykin <[email protected]>
Signed-off-by: Yaroslav Borbat <[email protected]>
@yaroslavborbat
resolve commits
3c4953a 
Signed-off-by: Yaroslav Borbat <[email protected]>
@yaroslavborbat
del f str
d53a7fe 
Signed-off-by: Yaroslav Borbat <[email protected]>
yaroslavborbat and others added 2 commits March 14, 2024 13:18
@yaroslavborbat @diafour
Update images/virtualization-artifact/hack/mirrord.sh
8ae5809 
Co-authored-by: Ivan Mikheykin <[email protected]>
Signed-off-by: Yaroslav Borbat <[email protected]>
@yaroslavborbat
fix
b1f2289 
Signed-off-by: Yaroslav Borbat <[email protected]>
@yaroslavborbat yaroslavborbat merged commit a737b08 into main Mar 14, 2024
5 checks passed
@yaroslavborbat yaroslavborbat deleted the feat/virtualization-api branch March 14, 2024 11:44
universal-itengineer pushed a commit that referenced this pull request Mar 20, 2024
@yaroslavborbat @universal-itengineer
feat(virtualization-api): first implementation (#11)
828836c 
Description
Added a new component virtualization-api - extension API server.

Why do we need it, and what problem does it solve?
Using the api server, we can connect to virtual machines and perform various operations. Currently implemented: console, vnc, port forwarding
---------
Signed-off-by: Yaroslav Borbat <[email protected]>
Signed-off-by: Yaroslav Borbat <[email protected]>
Co-authored-by: Ivan Mikheykin <[email protected]>
Signed-off-by: Nikita Korolev <[email protected]>
This was referenced May 7, 2024
Closed
Merged
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Aug 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diafour diafour diafour left review comments

@Isteb4k Isteb4k Isteb4k approved these changes

Assignees

@yaroslavborbat yaroslavborbat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yaroslavborbat @diafour @Isteb4k