-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(kube-api-rewriter): rewrite owner refs #108
Merged
LopatinDmitr
merged 23 commits into
main
from
refactor/kube-api-rewriter/rewrite-owner-refs-when-patching
May 31, 2024
Merged
refactor(kube-api-rewriter): rewrite owner refs #108
LopatinDmitr
merged 23 commits into
main
from
refactor/kube-api-rewriter/rewrite-owner-refs-when-patching
May 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add rewrite owner refs when patching - add debug out
- add rewrite owner reference for kubevirt and cdi related resources Signed-off-by: Dmitry Lopatin <[email protected]>
- add rewrite owner reference for RoleKind and RoleBinding Signed-off-by: Dmitry Lopatin <[email protected]>
- rolling back previous changes for RoleKind and RoleBinding Signed-off-by: Dmitry Lopatin <[email protected]>
Signed-off-by: Dmitry Lopatin <[email protected]>
- add debug logs Signed-off-by: Dmitry Lopatin <[email protected]>
Signed-off-by: Dmitry Lopatin <[email protected]>
- add res type for method 'ShouldRewriteRequest' Signed-off-by: Dmitry Lopatin <[email protected]>
- add rewrite owner ref into PATCH (for test) - add debug log Signed-off-by: Dmitry Lopatin <[email protected]>
- add debug logs Signed-off-by: Dmitry Lopatin <[email protected]>
- add rewrite for ControllerRevision and PodDisruptionBudget Signed-off-by: Dmitry Lopatin <[email protected]>
- delete edits with patching Signed-off-by: Dmitry Lopatin <[email protected]>
- refactor final's edits Signed-off-by: Dmitry Lopatin <[email protected]>
- add debug logs Signed-off-by: Dmitry Lopatin <[email protected]>
- add debug logs Signed-off-by: Dmitry Lopatin <[email protected]>
- add debug logs Signed-off-by: Dmitry Lopatin <[email protected]>
- add debug logs Signed-off-by: Dmitry Lopatin <[email protected]>
- add rewrite owner refs for default section Signed-off-by: Dmitry Lopatin <[email protected]>
- add rewrite owner refs for CRD and Role Signed-off-by: Dmitry Lopatin <[email protected]>
- refactor edits Signed-off-by: Dmitry Lopatin <[email protected]>
- rolling back changes Signed-off-by: Dmitry Lopatin <[email protected]>
- add rewrite for skipped resources Signed-off-by: Dmitry Lopatin <[email protected]>
diafour
reviewed
May 31, 2024
diafour
approved these changes
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small rename please.
- rename variable - remove comments Signed-off-by: Dmitry Lopatin <[email protected]>
LopatinDmitr
changed the title
refactor(kube-api-rewriter): rewrite owner refs when patching
refactor(kube-api-rewriter): rewrite owner refs
May 31, 2024
LopatinDmitr
deleted the
refactor/kube-api-rewriter/rewrite-owner-refs-when-patching
branch
May 31, 2024 10:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add rewrite owner refs
Why do we need it, and what problem does it solve?
What is the expected result?
Checklist