Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(kube-api-rewriter): rewrite owner refs #108

Merged

Conversation

LopatinDmitr
Copy link
Contributor

@LopatinDmitr LopatinDmitr commented May 23, 2024

Description

add rewrite owner refs

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

- add rewrite owner refs when patching
- add debug out
@LopatinDmitr LopatinDmitr marked this pull request as draft May 23, 2024 17:56
- add rewrite owner reference for kubevirt and cdi related resources

Signed-off-by: Dmitry Lopatin <[email protected]>
- add rewrite owner reference for RoleKind and RoleBinding

Signed-off-by: Dmitry Lopatin <[email protected]>
- rolling back previous changes for RoleKind and RoleBinding

Signed-off-by: Dmitry Lopatin <[email protected]>
- add debug logs

Signed-off-by: Dmitry Lopatin <[email protected]>
- add res type for method 'ShouldRewriteRequest'

Signed-off-by: Dmitry Lopatin <[email protected]>
- add rewrite owner ref into PATCH (for test)
- add debug log

Signed-off-by: Dmitry Lopatin <[email protected]>
- add debug logs

Signed-off-by: Dmitry Lopatin <[email protected]>
- add rewrite for ControllerRevision and PodDisruptionBudget

Signed-off-by: Dmitry Lopatin <[email protected]>
- delete edits with patching

Signed-off-by: Dmitry Lopatin <[email protected]>
- refactor final's edits

Signed-off-by: Dmitry Lopatin <[email protected]>
- add rewrite owner refs for default section

Signed-off-by: Dmitry Lopatin <[email protected]>
- add rewrite owner refs for CRD and Role

Signed-off-by: Dmitry Lopatin <[email protected]>
- add rewrite for skipped resources

Signed-off-by: Dmitry Lopatin <[email protected]>
@LopatinDmitr LopatinDmitr marked this pull request as ready for review May 30, 2024 22:21
@LopatinDmitr LopatinDmitr requested a review from diafour May 30, 2024 22:21
Copy link
Member

@diafour diafour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small rename please.

- rename variable
- remove comments

Signed-off-by: Dmitry Lopatin <[email protected]>
@LopatinDmitr LopatinDmitr changed the title refactor(kube-api-rewriter): rewrite owner refs when patching refactor(kube-api-rewriter): rewrite owner refs May 31, 2024
@LopatinDmitr LopatinDmitr merged commit 9426767 into main May 31, 2024
16 of 17 checks passed
@LopatinDmitr LopatinDmitr deleted the refactor/kube-api-rewriter/rewrite-owner-refs-when-patching branch May 31, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants