refactor(kube-api-rewriter): rewrite owner refs #105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add rewrite owner reference for kubevirt and cdi related resources Signed-off-by: Dmitry Lopatin <[email protected]>
LopatinDmitr
force-pushed
the
feat/kube-api-rewriter/rewrite-owner-refs
branch
from
bb0428e to
67f50ad
Compare
- add rewrite owner reference for RoleKind and RoleBinding Signed-off-by: Dmitry Lopatin <[email protected]>
fl64
changed the title
fl64
changed the title
- rolling back previous changes for RoleKind and RoleBinding Signed-off-by: Dmitry Lopatin <[email protected]>
Signed-off-by: Dmitry Lopatin <[email protected]>
- add debug logs Signed-off-by: Dmitry Lopatin <[email protected]>
Signed-off-by: Dmitry Lopatin <[email protected]>
- add res type for method 'ShouldRewriteRequest' Signed-off-by: Dmitry Lopatin <[email protected]>
- add rewrite owner ref into PATCH (for test) - add debug log Signed-off-by: Dmitry Lopatin <[email protected]>
- add debug logs Signed-off-by: Dmitry Lopatin <[email protected]>
- add rewrite for ControllerRevision and PodDisruptionBudget Signed-off-by: Dmitry Lopatin <[email protected]>
- delete edits with patching Signed-off-by: Dmitry Lopatin <[email protected]>
- refactor final's edits Signed-off-by: Dmitry Lopatin <[email protected]>
diafour
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add rewrite ownerReferences for all resources
Why do we need it, and what problem does it solve?
What is the expected result?
Checklist