Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[controller] Static linked nsenter, lsblk and lvm utils #30

Merged
merged 16 commits into from
Mar 15, 2024

Conversation

AleksZimin
Copy link
Member

@AleksZimin AleksZimin commented Mar 10, 2024

Description

This PR makes several key improvements to our sds-node-configurator:

  • We've switched to using statically linked nsenter, lsblk, and lvm utilities, ensuring they work reliably on any host without dependency issues.
  • The sds-node-configurator container is now distroless, enhancing security and reducing its footprint.
  • Error handling and logging within the sds-node-configurator have been improved, making it more robust and easier to troubleshoot.

Why do we need it, and what problem does it solve?

These changes address the need for more reliable storage utility execution across diverse environments, minimize potential compatibility issues, and improve the overall security and efficiency of our storage management operations.

What is the expected result?

  • Enhanced reliability and compatibility of storage utility execution.
  • A more secure and lightweight sds-node-configurator.
  • Improved error handling and logging for better operational insight and troubleshooting.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Signed-off-by: Aleksandr Zimin <[email protected]>
@AleksZimin AleksZimin added the enhancement New feature or request label Mar 10, 2024
@AleksZimin AleksZimin self-assigned this Mar 10, 2024
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
@AleksZimin AleksZimin force-pushed the static-lvm-and-lsblk branch 8 times, most recently from 47c974b to 038a0dd Compare March 14, 2024 21:40
@AleksZimin AleksZimin force-pushed the static-lvm-and-lsblk branch from 6d4e0f3 to 074dd51 Compare March 14, 2024 22:15
Signed-off-by: Aleksandr Zimin <[email protected]>
@AleksZimin AleksZimin force-pushed the static-lvm-and-lsblk branch from 5b33707 to e43cb3a Compare March 14, 2024 22:51
@dxavx dxavx self-requested a review March 15, 2024 12:21
@AleksZimin AleksZimin changed the title Static linked utils [controller] Static linked nsenter, lsblk and lvm utils Mar 15, 2024
@AleksZimin AleksZimin requested a review from apolovov March 15, 2024 16:25
@AleksZimin AleksZimin marked this pull request as ready for review March 15, 2024 16:26
@AleksZimin AleksZimin merged commit ca224e0 into main Mar 15, 2024
3 checks passed
@AleksZimin AleksZimin deleted the static-lvm-and-lsblk branch March 15, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants