Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[controller] Replace deprecated klogr.New with textlogger.NewLogger #20

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

AleksZimin
Copy link
Member

@AleksZimin AleksZimin commented Aug 29, 2024

Description

This PR addresses a deprecation warning related to the logger initialization. The previous implementation used klogr.New, which is deprecated due to its outdated output format. The logger has now been updated to use textlogger.NewLogger as recommended. This change ensures the logger is initialized using a more current and supported configuration.

Why do we need it, and what problem does it solve?

Updating the logger initialization prevents potential issues caused by relying on deprecated methods. This change ensures compatibility with the latest logging standards and improves the overall stability of the logging system.

What is the expected result?

  • The logger is now initialized with textlogger.NewLogger, eliminating the deprecation warning.
  • Improved compatibility with the current logging framework.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Signed-off-by: Aleksandr Zimin <[email protected]>
@AleksZimin AleksZimin added the enhancement New feature or request label Aug 29, 2024
@AleksZimin AleksZimin self-assigned this Aug 29, 2024
@AleksZimin AleksZimin changed the title [controller] Fix deprecations in logger [controller] Fix deprecated logger method in NewLogger function Aug 30, 2024
@AleksZimin AleksZimin changed the title [controller] Fix deprecated logger method in NewLogger function [controller] Replace deprecated klogr.New with textlogger.NewLogger Aug 30, 2024
@AleksZimin AleksZimin marked this pull request as ready for review August 30, 2024 08:44
@AleksZimin AleksZimin merged commit c01392f into main Aug 30, 2024
6 of 7 checks passed
@AleksZimin AleksZimin deleted the fix-logger branch August 30, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants