cpp-proio: fix for slow Skip() calls

Problem was that bucket bytes were not actually being skipped, and it was falling back on syncing to magic number.
decibelcooper · Jul 30, 2018 · cbc2416 · cbc2416
1 parent fe37685
commit cbc2416
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/cpp-proio/src/reader.cc b/cpp-proio/src/reader.cc
@@ -82,6 +82,8 @@ uint64_t Reader::Skip(uint64_t nEvents) {
             uint64_t nBucketEvents = bucketHeader->nevents();
             bucketIndex -= nBucketEvents;
             nSkipped += nBucketEvents - startIndex;
+            if (nBucketEvents > 0 && bucket->BytesRemaining() == 0)
+                if (!fileStream->Skip(bucketHeader->bucketsize())) throw ioError;
         }
         readHeader();
         if (!bucketHeader) return nSkipped;

diff --git a/cpp-proio/src/reader.h b/cpp-proio/src/reader.h
@@ -105,6 +105,10 @@ const class BadLZ4FrameError : public std::exception {
 const class SeekError : public std::exception {
     virtual const char *what() const throw() { return "Failed to seek file"; }
 } seekError;
+
+const class IOError : public std::exception {
+    virtual const char *what() const throw() { return "Unexpected IO Error"; }
+} ioError;
 }  // namespace proio
 
 #endif  // PROIO_READER_H