Earthid driver integration #441
Conversation
|
Thanks @vaibhavahire99 for your effort. This looks much better, but still one request.. This PR seems to add a lot of newlines to the docker-compose.yml file. Do you think you could also make this small change, so that you actually only add your driver and don't change other driver entries? Also, this PR doesn't seem to add your driver to application.yml and .env and README.md, as described here: https://github.com/decentralized-identity/universal-resolver/blob/main/docs/driver-development.md |
|
Hi thanks @peacekeeper. I've made the changes as mentioned. Can you please take a look and let me know if works. |
|
Hi, |
docker-compose.yml
Outdated
| @@ -374,3 +376,11 @@ services: | |||
| image: ghcr.io/iden3/driver-did-iden3:v0.0.4 | |||
| ports: | |||
| - "8152:8080" | |||
|
|
|||
| driver-did-earthid: | |||
| image: vibhi09/driver-did-earthid:latest | |||
There was a problem hiding this comment.
Please use a stable version instead of "latest"
There was a problem hiding this comment.
Sure let me retest and update the request.
There was a problem hiding this comment.
Hi @peacekeeper , I've updated the repo with a stable version and updated port number kindly review my latest commit in the current pull request and let me know if any changes required.
Thank you!
docker-compose.yml
Outdated
| environment: | ||
| baseUrl: "https://did.myearth.id/v1/resolve" | ||
| ports: | ||
| - "8153:8080" |
There was a problem hiding this comment.
We are using 8153 for the driver-did-prism
| - "8153:8080" | |
| - "8154:8080" |
There was a problem hiding this comment.
I've updated the port number as suggested. Please let me know if any changes.
|
@vaibhavahire99 It seems there are merge conflicts now that need to be resolved.. |
|
Hi @peacekeeper, I've resolved the conflicts can you please take a look and let me know. |
docker-compose.yml
Outdated
| @@ -380,3 +381,10 @@ services: | |||
| image: ghcr.io/fabiopinheiro/uni-resolver-driver-did-prism:0.2 | |||
| ports: | |||
| - "8153:9090" | |||
| driver-did-earthid: | |||
There was a problem hiding this comment.
Pls fix issue with indendation
| @@ -341,4 +341,7 @@ uniresolver: | |||
| - did:prism:c36cd59bbc62dee1925e1343a8fed051416e417116d6169d060746f1e6816cd4 | |||
| - did:prism:0d8481c41b654794f02922601f84811763c655dcfc376acf841eb996846d5e68 # deactivated | |||
| - did:prism:52e163e8e53466b808e53df870bccd0a066aa4d05af9b689f5c73edcbe23d625 # with updates | |||
|
|
|||
| - pattern: "^(did:earthid:.+)$" | |||
There was a problem hiding this comment.
Pls fix issue with indendation
|
Pls fix the issues with indendation and resolve new merge conflicts. We added a new driver in the meantime and that created new conflicts |
|
Hi @BernhardFuchs, I've resolved the conflicts and the indendation issues. Can you please check and let me know if any changes. |
|
There is still following error thrown: |
|
Hi @BernhardFuchs, I've updated the platform dependency. Can you please check now and let me know if any changes. |
|
Thx for the update but the driver still throws the same error on startup: |
|
I also tried it and got the same error as @BernhardFuchs . @vaibhavahire99 Have you tried testing your own driver locally according to https://github.com/decentralized-identity/universal-resolver/blob/main/docs/driver-development.md#how-to-test-a-driver-locally ? |
This pull request removes the driver-did-earthid directory from the Universal Resolver repository to comply with best practices of separating the driver code from the Universal Resolver core. The changes made in this pull request ensure that the Universal Resolver configuration references the EarthID driver Docker image hosted externally, rather than including the driver code in this repository.
Key Changes:
Removed driver-did-earthid directory:
The directory containing the EarthID driver code has been removed from the Universal Resolver repository.
This ensures that the driver implementation can evolve independently and is maintained separately.
Updated docker-compose.yml and configuration files:
The configuration now points to the vibhi09/driver-did-earthid:latest Docker image for resolving did:earthid identifiers.
The resolver setup will continue to support EarthID DIDs by referencing the external Docker image.