Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add did:btco driver. #388

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

brianorwhatever
Copy link
Contributor

This PR will be ready once the explorer at https://signet.ordinals.com has been updated to the latest release and I have tested the resolver against infrastructure I don't control.

@peacekeeper
Copy link
Member

Hello @brianorwhatever thanks for working on this; looking forward to adding support for did:btco !

@brianorwhatever
Copy link
Contributor Author

This is now ready for review the did spec registry PR is here w3c/did-extensions#541

@brianorwhatever brianorwhatever marked this pull request as ready for review December 23, 2023 05:49
@peacekeeper
Copy link
Member

@brianorwhatever When I try this, I get the following error:

 ! driver-did-btco The requested image's platform (linux/arm64) does not match the detected host platform (linux/amd64/v3) and no specific platform was requested                        0.0s 
Attaching to universal-resolver-driver-did-btco-1, universal-resolver-uni-resolver-web-1
universal-resolver-driver-did-btco-1   | exec /usr/local/bin/docker-entrypoint.sh: exec format error
universal-resolver-driver-did-btco-1 exited with code 1

I don't have much experience with supporting different platforms in Docker.. Do you know how to fix this? Maybe the image has to be built in a different way?

@brianorwhatever
Copy link
Contributor Author

@peacekeeper I can build it on a different platform. What should I use? I'm guessing linux/amd64?

@peacekeeper
Copy link
Member

Yes that would be good, thanks!

Copy link
Contributor

@kimdhamilton kimdhamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Brian, as part of Universal Resolver stability improvements, we're requiring use of a specific image version rather than "latest" (i.e. brianrichter/did-btco:latest). Can you tag it with a version and update the PR?

@@ -287,4 +287,10 @@ services:
image: kataru/content-did-driver:latest
ports:
- "8148:8888"

driver-did-btco:
image: brianrichter/did-btco:latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only tag available is latest. Ideally, please tag and push an image to a Docker registry with a semantic version number.

@peacekeeper
Copy link
Member

Hello @brianorwhatever, following up on this, would it be possible to update this PR with a stable driver version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants