Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/616 #617

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Feature/616 #617

merged 2 commits into from
Jan 17, 2024

Conversation

albinpa
Copy link
Contributor

@albinpa albinpa commented Jan 17, 2024

Steps to test this PR

Run the following commands from bb-consent-playground repository:

  1. To destroy all the running containers and their volumes, execute make destroy
  2. To build fixtures docker image, execute make build-fixtures
  3. To build BDD test runner docker image, execute make build-test
  4. In the API repository, switch to the feature/fix branch you wish to execute tests against and build a docker image by executing make build/docker/deployable
  5. Copy image name and paste it in image field value under api in test-docker-compose.yaml file inside test folder in bb-consent-playground

@albinpa albinpa self-assigned this Jan 17, 2024
@albinpa albinpa added the enhancement New feature or request label Jan 17, 2024
georgepadayatti
georgepadayatti requested changes Jan 17, 2024
View reviewed changes
Copy link
Member

@georgepadayatti georgepadayatti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for tests

@georgepadayatti georgepadayatti self-requested a review January 17, 2024 13:11
georgepadayatti
georgepadayatti approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@georgepadayatti georgepadayatti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acceptance criteria is met.

image

@georgepadayatti georgepadayatti merged commit c5a0165 into main Jan 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgepadayatti georgepadayatti georgepadayatti approved these changes

Assignees

@albinpa albinpa

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@albinpa @georgepadayatti