Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #594 Data agreement #596

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Add #594 Data agreement #596

merged 1 commit into from
Dec 18, 2023

Conversation

albinpa
Copy link
Contributor

@albinpa albinpa commented Dec 7, 2023

  • lifecycle field should be an object is not implemented.

@albinpa albinpa added the enhancement New feature or request label Dec 7, 2023
@albinpa albinpa self-assigned this Dec 7, 2023
Copy link
Member

@georgepadayatti georgepadayatti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@albinpa Comment:

  1. Make method of use non-mandatory if it is.
  2. If data use is not empty and is valid then populate method of use with the same
  3. If data use is empty, then populate with value present in method of use.

Copy link
Member

@georgepadayatti georgepadayatti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the necessary changes: #592 (comment)

@georgepadayatti georgepadayatti merged commit b2ac442 into main Dec 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants