Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/189 align apis to govstack #194

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

albinpa
Copy link
Contributor

@albinpa albinpa commented Oct 3, 2023

No description provided.

@albinpa albinpa added the enhancement New feature or request label Oct 3, 2023
@albinpa albinpa self-assigned this Oct 3, 2023
@albinpa albinpa force-pushed the feature/189-align-apis-to-govstack branch from ac70d36 to e3617af Compare October 3, 2023 10:22

// All http path url variables
const (
OrganizationId = "OrganizationID"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we use organistaionId as value ?

@@ -259,6 +259,15 @@ func Get(organizationID string) (Organization, error) {
return result, err
}

// Get Gets a single organization
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment should be

// GetOrganization Gets a single organization


// Application mode
const (
SingleTenat = "single-tenant"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be SingleTenant

@albinpa albinpa force-pushed the feature/189-align-apis-to-govstack branch from e3617af to bd15465 Compare October 4, 2023 06:22
@albinpa albinpa force-pushed the feature/189-align-apis-to-govstack branch from bd15465 to 3af2182 Compare October 4, 2023 06:41
@albinpa albinpa force-pushed the feature/189-align-apis-to-govstack branch from 3af2182 to 6d2843b Compare October 4, 2023 06:50
@georgepadayatti georgepadayatti merged commit 201a850 into main Oct 4, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants