This repository has been archived by the owner on Feb 21, 2024. It is now read-only.
Replace postgress with mongo #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| model Leaf { | ||
| address String @map("_id") | ||
| usdValue Int | ||
| merkleProof String[] |
There was a problem hiding this comment.
Question regarding the merkle proof. Why did this change from path, indices, and root?
There was a problem hiding this comment.
Yeah this should remain the same as path + indices --- and then we need to link the leaf to the group somehow (whether thats via a root other other)
| merkleRoot String @map("_id") | ||
| name String | ||
| threshold Int | ||
| erc20Addresses String[] |
There was a problem hiding this comment.
I am unsure if we need to save erc20 addresses since they will be available from the leaf object
There was a problem hiding this comment.
@christopherdancy -- where are the ERC20addresses on the leaf object? The leaf is only the address, balance, and proof currently.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
View the readme for instructions on setting up the db. Still using docker compose as before but you need to set the env variable in
.env.I set up a quick temporary test for the db in
scripts/index.ts. This scripts directory can be removed, it's just there for quickly testing db insertions.