-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-65]
[ENG-66]
Create example templates for Transfer, Airdrop and Sablier stream creation
#2647
base: feature/#2533-example-proposal-templates
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for decent-interface-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Looking good! The Airdrop functionality isn't working for me, the "Submit" button activates inconsistently and when I do press it, nothing happens. Looking good, though |
@parkermccurley Finally figured out what was wrong - can you check once more pls? |
…2533-sablier-and-transfer-template
[ENG-65]
[ENG-66]
Create example templates for Transfer, Airdrop and Sablier stream creation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After filling in the "airdrop" proposal template modal form, I'm presented with what looks like the the New Proposal metadata page (url confirms this), but the Preview card on the side is all filled out. On this /proposals/new/metadata page I still need to fill out at least the title. However, even with the title input field empty, the "Create" button at the bottom of the screen is enabled. When clicking it however, nothing user-facing happens. So thats probably a bug this button should be disabled until a title is entered.
I also have bigger comments regarding UX flow and URL structures but we'll get to that soon.
Certainly a bug - I'll look into that sir, thank you for noticing.
UX of this "Proposal with Actions" flow was implemented way earlier(oof, that was 2024 - now we're in 2025, time flies) rather as "Proof of Concept" and definitely requires design supervision and UX adjustments - I feel like we still wanna give user the ability to fill in some transactions but make it optional and have a way to both fill transactions or submit immediately. FYI - this "Proposal with Actions" was implemented as part of improvement for submitting "Request Payment" (aka "Send Assets") proposal and in my vision every thingy that leads to proposal creation should eventually direct user to this flow, giving the ability to add "global actions" to any proposal (like create roles + payments + "Add Action -> Request Payment" + "Add Action -> Change DAO Name" etc etc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, pending other comments
Also I see transfer action is not displayed in the list of actions which is wrong |
…2533-sablier-and-transfer-template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reported bug fixed, thanks @mudrila
Changes
This PR contains following functional changes
Testing
Issues
Screenshots