Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-65] [ENG-66] Create example templates for Transfer, Airdrop and Sablier stream creation #2647

Open
wants to merge 14 commits into
base: feature/#2533-example-proposal-templates
Choose a base branch
from

Conversation

mudrila
Copy link
Contributor

@mudrila mudrila commented Dec 20, 2024

Changes

This PR contains following functional changes

  • Implement "Example Templates" and display it for every DAO on any chain. Currently - there're 3 templates: "Transfer", "Airdrop Tokens", "Create Sablier Stream"
  • Implement "Airdrop Tokens" feature - it mostly replicates "Send Assets" experience. Filling and submitting the form in the modal will take user to the "Proposal With Actions" form with the ability to add more actions to the proposal and fill in title, description and documentation link
  • Example template for "Transfer" simply leverages existing "Send Assets" UI / UX and replicates behavior for "Request Payment" on "Treasury" page
  • Example template for "Create Sablier Stream" simply navigates to "Create Sablier Proposal" UI.

Testing

  1. Navigate to DAO's Proposal Templates page (from the Dashboard: "Create Proposal" -> "Browse Templates")
  2. Verify that new section with "Pre-configured Templates" available for any DAO on any chain. It should have 3 templates: "Transfer", "Airdrop Tokens", "Create Sablier Stream"
  3. Verify that "Transfer" template correctly opens "Send Assets Modal", filling and submitting form should navigate to "Create Proposal With Actions" form, where "Send Assets" action will be added in the actions list
  4. Verify that "Airdrop Tokens" template correctly opens respective modal, filling and submitting form should navigate to "Create Proposal With Actions" form, where "Airdrop" action will be added in the actions list
  5. Verify that "Create Sablier Stream" navigates to "Create Sablier Proposal". Filling the form immediately submits the proposal with filled title, description, documentation link and respective streams. For now it supports only tranched streams creation

Issues

Screenshots

Screenshot 2024-12-20 at 23 41 32

@mudrila mudrila added the enhancement New feature or request label Dec 20, 2024
@mudrila mudrila self-assigned this Dec 20, 2024
Copy link

netlify bot commented Dec 20, 2024

Deploy Preview for decent-interface-dev ready!

Name Link
🔨 Latest commit 13f2d12
🔍 Latest deploy log https://app.netlify.com/sites/decent-interface-dev/deploys/6781348a1c35960008c36e13
😎 Deploy Preview https://deploy-preview-2647.app.dev.decentdao.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@parkermccurley
Copy link

Looking good! The Airdrop functionality isn't working for me, the "Submit" button activates inconsistently and when I do press it, nothing happens. Looking good, though

@mudrila
Copy link
Contributor Author

mudrila commented Dec 21, 2024

Looking good! The Airdrop functionality isn't working for me, the "Submit" button activates inconsistently and when I do press it, nothing happens. Looking good, though

@parkermccurley Finally figured out what was wrong - can you check once more pls?

@mudrila mudrila changed the title Create example templates for transfer and Sablier stream [ENG-65] [ENG-66] Create example templates for Transfer, Airdrop and Sablier stream creation Jan 7, 2025
Copy link
Member

@adamgall adamgall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After filling in the "airdrop" proposal template modal form, I'm presented with what looks like the the New Proposal metadata page (url confirms this), but the Preview card on the side is all filled out. On this /proposals/new/metadata page I still need to fill out at least the title. However, even with the title input field empty, the "Create" button at the bottom of the screen is enabled. When clicking it however, nothing user-facing happens. So thats probably a bug this button should be disabled until a title is entered.

I also have bigger comments regarding UX flow and URL structures but we'll get to that soon.

@mudrila
Copy link
Contributor Author

mudrila commented Jan 7, 2025

After filling in the "airdrop" proposal template modal form, I'm presented with what looks like the the New Proposal metadata page (url confirms this), but the Preview card on the side is all filled out. On this /proposals/new/metadata page I still need to fill out at least the title. However, even with the title input field empty, the "Create" button at the bottom of the screen is enabled. When clicking it however, nothing user-facing happens. So thats probably a bug this button should be disabled until a title is entered.

Certainly a bug - I'll look into that sir, thank you for noticing.

I also have bigger comments regarding UX flow and URL structures but we'll get to that soon.

UX of this "Proposal with Actions" flow was implemented way earlier(oof, that was 2024 - now we're in 2025, time flies) rather as "Proof of Concept" and definitely requires design supervision and UX adjustments - I feel like we still wanna give user the ability to fill in some transactions but make it optional and have a way to both fill transactions or submit immediately.

FYI - this "Proposal with Actions" was implemented as part of improvement for submitting "Request Payment" (aka "Send Assets") proposal and in my vision every thingy that leads to proposal creation should eventually direct user to this flow, giving the ability to add "global actions" to any proposal (like create roles + payments + "Add Action -> Request Payment" + "Add Action -> Change DAO Name" etc etc)

Da-Colon
Da-Colon previously approved these changes Jan 8, 2025
Copy link
Contributor

@Da-Colon Da-Colon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, pending other comments

@Da-Colon Da-Colon dismissed their stale review January 8, 2025 09:57

Found a bug

@Da-Colon
Copy link
Contributor

Da-Colon commented Jan 8, 2025

Maybe related to the work here if not, I can spin into a new linear issue. but when I fill out transfer action form and go the the proposal create page view.

image

The submit button is highlighted to begin with but once I add a title or description it becomes disabled.

@mudrila
Copy link
Contributor Author

mudrila commented Jan 10, 2025

Maybe related to the work here if not, I can spin into a new linear issue. but when I fill out transfer action form and go the the proposal create page view.

image

The submit button is highlighted to begin with but once I add a title or description it becomes disabled.

Also I see transfer action is not displayed in the list of actions which is wrong

Copy link

cloudflare-workers-and-pages bot commented Jan 10, 2025

Deploying decent-interface with  Cloudflare Pages  Cloudflare Pages

Latest commit: 13f2d12
Status:🚫  Build failed.

View logs

@mudrila mudrila requested review from adamgall and Da-Colon January 10, 2025 14:54
@mudrila
Copy link
Contributor Author

mudrila commented Jan 10, 2025

@adamgall @Da-Colon All the issues should be resolved - kindly asking for re-review

Copy link
Contributor

@Da-Colon Da-Colon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reported bug fixed, thanks @mudrila

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants