[Bugfix | No Issue] Add useEffect for when wallet is connected to different network
#2642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for decent-interface-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
DarksightKellar
approved these changes
Dec 19, 2024
| @@ -113,7 +113,7 @@ export function EstablishEssentials(props: ICreationStepProps) { | |||
| const chainId = getChainIdFromPrefix(addressPrefix); | |||
| switchChain({ chainId }); | |||
| } | |||
| }); | |||
| }, [chain.id, walletChainID, addressPrefix, switchChain]); | |||
There was a problem hiding this comment.
@Da-Colon With these deps, I'm worried about what might happen if the user switches their wallet network themselves, resulting in walletChainID being different from chain.id (right?), and triggering a call to switchChain to chainId from unchanged addressPrefix
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that the wallet wouldn't switch to ethereum on page load and that switching networks via the selection wasn't causing hte network to change