Refactor useResolveAddressMultichain to useResolveENSName
#2637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Da-Colon
changed the base branch from
develop
to
issue/2565-network-config-updates
✅ Deploy Preview for decent-interface-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…S address resolution
…for single address resolution
…tion and update resolved address handling
Da-Colon
force-pushed
the
issue/2565-resolve-mainnet-ens
branch
from
4cbf0c5 to
8fc85e2
Compare
Da-Colon
changed the title
useResolveAddressMultichain to useResolveENSName
…d update related logic
adamgall
requested changes
Dec 16, 2024
src/hooks/utils/useResolveENSName.ts
Outdated
Comment on lines
50
to
58
| try { | ||
| const resolvedAddress = await mainnetPublicClient.getEnsAddress({ name: normalizedName }); | ||
| if (resolvedAddress) { | ||
| returnedResult.resolvedAddress = resolvedAddress; | ||
| returnedResult.isValid = true; | ||
| } | ||
| } catch { | ||
| // do nothing | ||
| } |
There was a problem hiding this comment.
I don't think this try/catch is necessary any longer. I believe it was here previously to catch the error in .getEnsAddress when the call was made on a network that didn't ahve the ENS contracts deployed (all of them except for mainnet and sepolia IIRC).
adamgall
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@adamgall
Very similar to
useAddress.Main difference it that the execution the lookup doesn't kickoff via
useEffectbut rather the hook spits out the function to be used as directed.if you prefer I just refactor this back and fit
useAddressin I can do that. I just prefer using acallbackfunction to time the execution