[Issue #2565] Cross-chain Safe search
#2630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…turn found network prefixes
✅ Deploy Preview for decent-interface-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
DarksightKellar
approved these changes
Dec 13, 2024
adamgall
approved these changes
Dec 13, 2024
Da-Colon
commented
Dec 14, 2024
There was a problem hiding this comment.
Did some clean. Summary
- Reverted Changes in
useIsSafehook - moved specialized code into
useSearchDAOhook for a smoother multi-chain experience - added new
useResolvedAddressMultiChain()hook, similar to ouruseAddressbut checks multiple networks - updated
useSearchDAOhook accordingly
There was a problem hiding this comment.
New hook to handle multi-chain address resolving. similar to our useAddress hook.
similarly takes a string as an input, but instead of resolving a single chain, loops through all supported networks and resolves the input if its a valid ENS name.
If input is an Address returns valid on all networks
| const [searchString, setSearchString] = useState<string>(''); | ||
| const [errorMessage, setErrorMessage] = useState<string>(); | ||
|
|
||
| const { address, isValid, isLoading: isAddressLoading } = useAddress(searchString); | ||
| const { isSafe, isSafeLoading } = useIsSafe(address); |
There was a problem hiding this comment.
I reverted changes I made to useIsSafe and instead of continue updating that hook for use here just pulled in what was needed and removed relying on conditional useEffect and more intentionally call to resolve searchInput.
…tdao/decent-interface into issue/2565-cross-chain-dao-search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well was trying to show DAO is found on Sepolia, wallet is connected to Ethereum.
