ENG-1 Fixed "My DAOs" menu update issue when DAOs are favorited/unfavorited. #2628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnqh
requested review from
adamgall,
DarksightKellar,
mudrila and
Da-Colon
✅ Deploy Preview for decent-interface-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
adamgall
approved these changes
Dec 12, 2024
Da-Colon
approved these changes
Dec 12, 2024
DarksightKellar
approved these changes
Dec 13, 2024
mudrila
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useState is local to the component. So when the state is changed in one component, it is not changed in other components even if they appear to be using the same state.
I found a little library called useBetween. It triggers state updates in all components with useState on the same field. This seems to be the fix with the lightest changes.