Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove underlyingTokenAddress and loadUnderlyingERC20Token #2625

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Remove underlyingTokenAddress and loadUnderlyingERC20Token #2625

merged 2 commits into from
Dec 13, 2024

Conversation

DarksightKellar
Copy link
Contributor

Closes #2614

underlyingTokenAddress was left unused after wrap functionality rip. Removed

@netlify Netlify
Copy link

netlify bot commented Dec 11, 2024 •
edited
Loading

✅ Deploy Preview for decent-interface-dev ready!

Name Link
🔨 Latest commit 28662e4
🔍 Latest deploy log https://app.netlify.com/sites/decent-interface-dev/deploys/6759ba043a258d00087bf6b9
😎 Deploy Preview https://deploy-preview-2625.app.dev.decentdao.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

adamgall
adamgall reviewed Dec 11, 2024
View reviewed changes
Copy link
Member

@adamgall adamgall left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can probably also keep going and remove the SET_UNDERLYING_TOKEN_DATA action&reducer from FractalGovernanceAction too, right?

@DarksightKellar
Copy link
Contributor Author

Can probably also keep going and remove the SET_UNDERLYING_TOKEN_DATA action&reducer from FractalGovernanceAction too, right?

Absolutely, thanks!

@DarksightKellar DarksightKellar merged commit f586211 into develop Dec 13, 2024
7 checks passed
@DarksightKellar DarksightKellar deleted the remove-underlying-token-address branch December 13, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Da-Colon Da-Colon Da-Colon approved these changes

@adamgall adamgall adamgall approved these changes

@mudrila mudrila Awaiting requested review from mudrila

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Underlying Token Address not being set
3 participants
@DarksightKellar @adamgall @Da-Colon