[PRD | Issue #2618] Copy updates
#2619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for decent-interface-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Looks good, thanks David! |
Merged
src/i18n/locales/en/breadcrumbs.json
Outdated
| @@ -12,6 +12,6 @@ | |||
| "proposalTemplate": "{{proposalTemplateTitle}}", | |||
| "proposalTemplateNew": "Create Proposal Template", | |||
| "editDAO": "Edit DAO", | |||
| "parentLink": "Parent-Safe", | |||
| "parentLink": "Parent-DAO", | |||
There was a problem hiding this comment.
Is the hyphen here intentional? Never really noticed it until now
cc @parkermccurley
There was a problem hiding this comment.
I think the hyphen here is out of place and should be removed
DarksightKellar
approved these changes
Dec 10, 2024
adamgall
requested changes
Dec 10, 2024
src/i18n/locales/en/breadcrumbs.json
Outdated
| @@ -12,6 +12,6 @@ | |||
| "proposalTemplate": "{{proposalTemplateTitle}}", | |||
| "proposalTemplateNew": "Create Proposal Template", | |||
| "editDAO": "Edit DAO", | |||
| "parentLink": "Parent-Safe", | |||
| "parentLink": "Parent-DAO", | |||
There was a problem hiding this comment.
I think the hyphen here is out of place and should be removed
adamgall
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2618
Parent-Safe -> Parent-DAO
Governance Parameters -> Governance
Governance Parameters -> Governance
Add period to end of sentence