-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ui tweaks 1 #2601
Ui tweaks 1 #2601
Conversation
✅ Deploy Preview for decent-interface-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple minor comments but otherwise - looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Within "Governance Parameters"
Replace the color blocks around the info with a Neutral 3 outline. Current color blocks are very low contrast and don't need to have a separate fill.
( we fill surfaces to indicate interactivity and outline content that is readable but not interactive)
Also please reduce the gap between both blocks to 0.5rem
Leave "Add Permissions" button up top.
@nicolaus-sherrill EDIT: Gonna go with 1.5rem until pushback if any Also the "Add Permissions" being at the bottom was an ask in the PRD (the comment is gone now but @parkermccurley can you confirm) |
@DarksightKellar With the titles contained within the card there, 0.5 rem would've been the call. |
Addresses the following:
Screenshots: