-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement progress stepper bar in create DAO workflow #2598
Conversation
✅ Deploy Preview for decent-interface-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Implementation looks good across the options, and good thinking about standardizing the number of steps for each configuration. I do think that a number and text is really important to provide adequate context to the user along the way, so I want to push for a solution that includes that context.
It sounds like we (design) don't understand the configuration steps deep enough yet. I wonder how we could standardize this workflow so that each step on the progress indicator is the same. It's perfectly okay for a step in the progress indicator to actually include multiple steps within it. They act more like chapters or buckets than 1:1 screen specific steppers. So how might we label those steps to properly capture the information being collected in each of the three parts? |
…governance options
Wow @adamgall! This looks great! I like the border-radius at the ends of the "step" visual indicators, it pairs nicely with the border-radius of the container beneath it. Nice work. I am wondering if "Configure Parent Controls" is the right heading. What about "Configure Administration" or "Configure Admin"? 🤔 |
@adamgall can we align the titles? Like in the designs. This is also happening in "Create Proposal". |
@parkermccurley @xanaramoss i've created new issues for each of your comments. In the future, once a PR has already been merged, leaving comments on it asking for changes isn't the appropriate place for those requests. Please feel empowered to create new issues yourself! |
Closes #2535
These are the different paths that might happen in the "create dao" workflow, and the titles of the different steppers:
Here are a non-exhaustive set of screenshots:
Create New DAO
Step 1, three different governance options
Create SubDAO
Step 1, three different governance options