Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement progress stepper bar in create DAO workflow #2598

Merged
merged 11 commits into from
Dec 5, 2024

Conversation

adamgall
Copy link
Member

@adamgall adamgall commented Dec 5, 2024

Closes #2535

These are the different paths that might happen in the "create dao" workflow, and the titles of the different steppers:

Create New DAO
	Azorius ERC-20
		1. Get Started
		2. Configure ERC-20 Token
		3. Governance Parameters
	Azorius ERC-721
		1. Get Started
		2. Configure ERC-721 NFTs
		3. Governance Parameters
	Multisig
		1. Get Started
		2. Configure Multisig
Create SubDAO
	Azorius ERC-20
		1. Get Started
		2. Configure ERC-20 Token
		3. Governance Parameters
		4. Configure Parent Controls
	Azorius ERC-721
		1. Get Started
		2. Configure ERC-721 NFTs
		3. Governance Parameters
		4. Configure Parent Controls
	Multisig
		1. Get Started
		2. Configure Multisig
		3. Configure Parent Controls
Edit DAO
	Multisig
		1. Get Started
		2. Configure Multisig
		3. Governance Parameters
  • Each breadcrumb matches the Page Title ("Create New DAO", "Create SubDAO", "Edit DAO"), which comes from the context that the "create dao" workflow was entered.
  • The Page Title ("Create New DAO", "Create SubDAO", "Edit DAO") stays consistent/static throughout the steps.

Here are a non-exhaustive set of screenshots:

Create New DAO

Step 1, three different governance options

Screenshot 2024-12-05 at 4 35 15 PM
Screenshot 2024-12-05 at 4 35 23 PM
Screenshot 2024-12-05 at 4 35 29 PM

Create SubDAO

Step 1, three different governance options

Screenshot 2024-12-05 at 4 35 52 PM
Screenshot 2024-12-05 at 4 36 21 PM
Screenshot 2024-12-05 at 4 36 27 PM

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for decent-interface-dev ready!

Name Link
🔨 Latest commit 13b0c3f
🔍 Latest deploy log https://app.netlify.com/sites/decent-interface-dev/deploys/67522b1c41d47700080b6547
😎 Deploy Preview https://deploy-preview-2598.app.dev.decentdao.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nicolaus-sherrill
Copy link

@adamgall

Implementation looks good across the options, and good thinking about standardizing the number of steps for each configuration. I do think that a number and text is really important to provide adequate context to the user along the way, so I want to push for a solution that includes that context.

This because you can't really predict what the different sections will be until we get there. Different selections along the way will dictate different steps being displayed.

It sounds like we (design) don't understand the configuration steps deep enough yet. I wonder how we could standardize this workflow so that each step on the progress indicator is the same. It's perfectly okay for a step in the progress indicator to actually include multiple steps within it. They act more like chapters or buckets than 1:1 screen specific steppers.

So how might we label those steps to properly capture the information being collected in each of the three parts?

@adamgall adamgall merged commit 6ba77e6 into develop Dec 5, 2024
7 checks passed
@adamgall adamgall deleted the new-dao-progress-bar branch December 5, 2024 22:42
@parkermccurley
Copy link

Wow @adamgall! This looks great! I like the border-radius at the ends of the "step" visual indicators, it pairs nicely with the border-radius of the container beneath it.

Nice work.

I am wondering if "Configure Parent Controls" is the right heading. What about "Configure Administration" or "Configure Admin"? 🤔

@xanaramoss
Copy link

@adamgall can we align the titles? Like in the designs. This is also happening in "Create Proposal".

Screenshot 2024-12-06 at 14 48 33 Screenshot 2024-12-06 at 14 49 53

This was referenced Dec 6, 2024
@adamgall
Copy link
Member Author

adamgall commented Dec 6, 2024

@parkermccurley @xanaramoss i've created new issues for each of your comments.

#2603
#2602

In the future, once a PR has already been merged, leaving comments on it asking for changes isn't the appropriate place for those requests. Please feel empowered to create new issues yourself!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create safe progress bar
4 participants